Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade-Client Followup #2 #7460

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Upgrade-Client Followup #2 #7460

merged 3 commits into from
Oct 6, 2020

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented Oct 5, 2020

Description

Upgrades to tendermint clients must now use the same client-chosen parameters as the previous client. This prevents a relayer from being able to modify any client-chosen parameter from the original parameters set by the relayer who created the client.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@AdityaSripal AdityaSripal changed the title Upgrade-Client Followup 2 Upgrade-Client Followup #2 Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #7460 into master will increase coverage by 0.00%.
The diff coverage is 62.50%.

@@           Coverage Diff           @@
##           master    #7460   +/-   ##
=======================================
  Coverage   55.24%   55.25%           
=======================================
  Files         591      591           
  Lines       36932    36948   +16     
=======================================
+ Hits        20404    20414   +10     
- Misses      14422    14426    +4     
- Partials     2106     2108    +2     

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks!

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 6, 2020
@colin-axner colin-axner added this to the IBC 1.0 [Implementation] milestone Oct 6, 2020
@mergify mergify bot merged commit c9cb02e into master Oct 6, 2020
@mergify mergify bot deleted the aditya/upgrade-followup-2 branch October 6, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants