Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nil instead of protobuf.Empty in genesis BaseAccount #7463

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

amaury1093
Copy link
Contributor

Description

Accounts in the 0.37 exported state don't have pubkeys. When migrating these accounts to 0.40, we were packing a protobuf's Empty inside the BaseAccount's pubkey Any field.

It would be much simpler to just pack a nil, which outputs as null in the JSON.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #7463 into master will increase coverage by 2.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7463      +/-   ##
==========================================
+ Coverage   55.25%   57.68%   +2.43%     
==========================================
  Files         591      288     -303     
  Lines       36948    19575   -17373     
==========================================
- Hits        20414    11292    -9122     
+ Misses      14426     7217    -7209     
+ Partials     2108     1066    -1042     

@amaury1093 amaury1093 marked this pull request as draft October 6, 2020 15:28
@amaury1093 amaury1093 marked this pull request as ready for review October 6, 2020 15:32
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 6, 2020
@mergify mergify bot merged commit 090bae5 into master Oct 6, 2020
@mergify mergify bot deleted the am-nil-pubkey branch October 6, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants