Remove reproducible builder image #7484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image has been moved to gh/tendemrint/images.
jgimeno
approved these changes
Oct 8, 2020
sahith-narahari
approved these changes
Oct 8, 2020
tac0turtle
reviewed
Oct 8, 2020
| @@ -122,10 +122,10 @@ build-simd-all: go.sum | |||
| docker cp -a latest-build:/home/builder/artifacts/ $(CURDIR)/ | |||
|
|
|||
| build-simd-linux: go.sum $(BUILDDIR)/ | |||
| $(if $(shell docker inspect -f '{{ .Id }}' cosmossdk/rbuilder 2>/dev/null),$(info found image cosmossdk/rbuilder),docker pull cosmossdk/rbuilder:latest) | |||
| docker pull cosmossdk/rbuilder:latest | |||
There was a problem hiding this comment.
not needed, docker run will pull if the image is not present
There was a problem hiding this comment.
will remove in another pr
tac0turtle
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image has been moved to gh/tendemrint/images.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes