x/cap: fix comments, SetIndex, and some tests #7845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebuchman
requested review from
aaronc,
alessio and
alexanderbez
as code owners
ebuchman
changed the title
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #7845 +/- ##
==========================================
- Coverage 54.24% 54.23% -0.02%
==========================================
Files 609 609
Lines 38804 38807 +3
==========================================
- Hits 21049 21046 -3
- Misses 15601 15604 +3
- Partials 2154 2157 +3 |
alessio
reviewed
Nov 7, 2020
Comment on lines
+127
to
+128
| latest := k.GetLatestIndex(ctx) | ||
| if latest > 0 { |
There was a problem hiding this comment.
nit
Suggested change
| latest := k.GetLatestIndex(ctx) | |
| if latest > 0 { | |
| if latest := k.GetLatestIndex(ctx); latest > 0 { |
There was a problem hiding this comment.
There isn't even a need to store this in a variable.
There was a problem hiding this comment.
I kind of prefer the clarity of how its written currently for symmetry with the other index value being evaluated.
alessio
reviewed
Nov 7, 2020
alessio
approved these changes
Nov 7, 2020
alexanderbez
approved these changes
Nov 7, 2020
Co-authored-by: Alessio Treglia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surfaced from Informal Systems IBC Audit of cosmos-sdk hash 82f15f3.
Description
Fixes comments and some tests and add's more constraints to SetIndex per #7805
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes