Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshots: fix flaky tests #8475

Merged
merged 2 commits into from
Feb 1, 2021
Merged

snapshots: fix flaky tests #8475

merged 2 commits into from
Feb 1, 2021

Commits on Jan 29, 2021

  1. snapshots: fix flaky tests

    The use testing.T.TempDir() seems to cause test failures
    in CI environvements in those cases where temporary
    directories' subdirs are created with permissions that
    are different from the defaults used by testing.T.TempDir().
    The snapshots package's tests seem to be heavily affected,
    thus this replaces testing.T.TempDir() occurrences with
    ioutil.TempDir() calls.
    
    Related upstream issue:
    - golang/go#40853
    Alessio Treglia committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    1d289c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Configuration menu
    Copy the full SHA
    3c664b8 View commit details
    Browse the repository at this point in the history