Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v0.41.x] Mega Docs cherry-pick PR #8576

Merged
merged 8 commits into from
Feb 15, 2021
Merged

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Feb 12, 2021

Description

This PR cherry-picks multiple docs backport PRs from master. See #8564 for details.

Please note that because of merge conflicts in proto-docs.md, I ran make proto-gen again in the final commit.

edit: @alessio Are you okay for cherry-picking multiple commits into one backport PR for docs only? the other 0.41.1 backport PRs will be individual.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

jgimeno and others added 7 commits February 12, 2021 12:43
Still a problem with `cat` - a tmp_genesis file needs to be created and then moved to the old location

Co-authored-by: Amaury <[email protected]>
Co-authored-by: Cory <[email protected]>
* Finish updating state

* Add messages

* Update events

* proto-gen

* Update proto/cosmos/staking/v1beta1/staking.proto

Co-authored-by: Anil Kumar Kammari <[email protected]>

* progo-gen

* Update Msg with slash

* Rerun proto docs

Co-authored-by: Anil Kumar Kammari <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* EndBlock: "beginning" => "end"

* misc fixes

* beginning => end

* fix error in run-node tutorial

* Use correct keyring backend when interacting

* multiply stakes by 1000

* query accounts with the bank submodule, not accounts

* specify key backend for transactions

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: SaReN <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@amaury1093 amaury1093 added the T:Docs Changes and features related to documentation. label Feb 12, 2021
@amaury1093 amaury1093 added this to the v0.41.1 milestone Feb 12, 2021
@amaury1093
Copy link
Contributor Author

Proto breaking because of:

<input>:1:1:Previously present file "cosmos/authz/v1beta1/authz.proto" was deleted.
<input>:1:1:Previously present file "cosmos/authz/v1beta1/genesis.proto" was deleted.
// etc
make: *** [proto-check-breaking] Error 1
Makefile:393: recipe for target 'proto-check-breaking' failed
Error: Process completed with exit code 2.

I think buf's proto breaking linter is not clever enough to understand multiple branches. imo this warning is safe to ignore.

@amaury1093 amaury1093 mentioned this pull request Feb 12, 2021
23 tasks
@amaury1093 amaury1093 changed the title [backport 0.41.x] Mega Docs cherry-pick PR [backport/0.41.x] Mega Docs cherry-pick PR Feb 15, 2021
@amaury1093 amaury1093 changed the title [backport/0.41.x] Mega Docs cherry-pick PR [backport/v0.41.x] Mega Docs cherry-pick PR Feb 15, 2021
@alessio alessio merged commit 2c52cb4 into release/v0.41.x Feb 15, 2021
@alessio alessio deleted the am-backport-docs branch February 15, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants