Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow REST endpoint to query txs with multisig #8730

Merged
merged 8 commits into from
Mar 1, 2021
Merged

Conversation

amaury1093
Copy link
Contributor

Description

closes: #8679


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #8730 (f6d6f52) into master (dbb9923) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8730      +/-   ##
==========================================
- Coverage   61.38%   61.38%   -0.01%     
==========================================
  Files         671      671              
  Lines       38343    38346       +3     
==========================================
+ Hits        23536    23537       +1     
- Misses      12348    12349       +1     
- Partials     2459     2460       +1     
Impacted Files Coverage Δ
x/auth/legacy/legacytx/stdtx.go 80.64% <33.33%> (-1.58%) ⬇️

@amaury1093 amaury1093 force-pushed the am/8679-legacy-msig branch 2 times, most recently from 68c4312 to 6b3fab5 Compare March 1, 2021 11:48
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 1, 2021
Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alessio
Copy link
Contributor

alessio commented Mar 1, 2021

@AmauryM tests are failing :-/

@mergify mergify bot merged commit 3832860 into master Mar 1, 2021
@mergify mergify bot deleted the am/8679-legacy-msig branch March 1, 2021 13:01
mergify bot pushed a commit that referenced this pull request Mar 1, 2021
* Fix unpack stdtx

* Add test for multisig

* remove println

* Add changelog

* Better UnpackInterfaces

Co-authored-by: Alessio Treglia <[email protected]>
(cherry picked from commit 3832860)

# Conflicts:
#	CHANGELOG.md
@zmanian
Copy link
Member

zmanian commented Mar 1, 2021

Are we going to backport this to stargate ?

@alessio
Copy link
Contributor

alessio commented Mar 1, 2021

Are we going to backport this to stargate ?

This -> #8731 👍

alessio pushed a commit that referenced this pull request Mar 1, 2021
(cherry picked from commit 3832860)

From: #8730

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Amaury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy Multisig transactions are not available on the legacy endpoints
5 participants