Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyring migration #9221

Closed
wants to merge 39 commits into from
Closed

Keyring migration #9221

wants to merge 39 commits into from

Conversation

cyberbono3
Copy link
Contributor

@cyberbono3 cyberbono3 commented Apr 28, 2021 •
edited
Loading

Description

Closed

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

amaury1093 and others added 30 commits April 16, 2021 18:00
@amaury1093
Add comment on x/auth hacky migration script (#9132)
b4fc48c 
* Add comment on x/auth hacky migration script

* QueryServer -> QueryRouter
@RiccardoM @michaelfig @amaury1093
Set proper default command output (#8628)
96fe999 
* Set proper default command output

* Removed duplicated cmd.SetErr(cmd.ErrOrStderr()) and cmd.SetOut(cmd.OutOrStdout())

* Moved command initialization and added CHANGELOG

* fix: groom all uses of cmd.Print*

* Ran make format

Co-authored-by: Michael FIG <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Amaury <[email protected]>
@dependabot
build(deps): bump codecov/codecov-action from v1.3.2 to v1.4.0 (#9136)
1bb71f8 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.3.2 to v1.4.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1.3.2...0e28ff8)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
internal/conv: fix wrong string to bytes implementation (#9141)
d3769b2 
UnsafeStrToBytes is currently not safe for -d=checkptr=2, since when it
cast from smaller struct (string) to bigger struct ([]byte). That causes
checkptr complains as the casting straddle multiple heap objects.

To fix this, we have to get the string header first, then use its fields
to construct the slice.

New implementation performs the same speed with the old (wrong) one.

name                old time/op    new time/op    delta
UnsafeStrToBytes-8    25.7ns ± 1%    25.7ns ± 3%   ~     (p=0.931 n=10+17)

name                old alloc/op   new alloc/op   delta
UnsafeStrToBytes-8     7.00B ± 0%     7.00B ± 0%   ~     (all equal)

name                old allocs/op  new allocs/op  delta
UnsafeStrToBytes-8      0.00           0.00        ~     (all equal)

While at it, also simplify UnsafeBytesToStr implementation, since when
we can pass the slice directly to unsafe.Pointer, instead of getting the
slice header first.
@fdymylja @robert-zaremba @tac0turtle
ADR036: Arbitrary signature (#7727)
83645e0 
* add: arbitrary signature adr draft

* fix: adr number

* change: adjust scope, address feedback

* fix: missing sentence

* change: address wording

Co-authored-by: Robert Zaremba <[email protected]>

* change: address wording and formatting

Co-authored-by: Robert Zaremba <[email protected]>

* change: address formatting

Co-authored-by: Robert Zaremba <[email protected]>

* change: message name, address modal verbs changes

* change: document how MsgSignData should be used

* change: address wording

Co-authored-by: Robert Zaremba <[email protected]>

* add: how verification works

* Update docs/architecture/adr-036-arbitrary-signature.md

* Update docs/architecture/adr-036-arbitrary-signature.md

Co-authored-by: Robert Zaremba <[email protected]>

* Apply suggestions from code review

* Update docs/architecture/adr-036-arbitrary-signature.md

* add: expand further discussion items

* fix: wording

* add: context references

* change: split offchain tx specific from MsgSignData

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Marko <[email protected]>
@tac0turtle
consistency in antehandler (#9144)
b1cf479
@dependabot
build(deps): bump github.com/confio/ics23/go from 0.6.3 to 0.6.6 (#9142)
9fd866e 
Bumps [github.com/confio/ics23/go](https://github.com/confio/ics23) from 0.6.3 to 0.6.6.
- [Release notes](https://github.com/confio/ics23/releases)
- [Commits](cosmos/ics23@v0.6.3...go/v0.6.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump codecov/codecov-action from v1.4.0 to v1.4.1 (#9154)
045c45f 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.4.0 to v1.4.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1.4.0...967e2b3)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@clevinson @amaury1093 @aaronc
Add support for permanent locked vesting accounts (#8520)
603e895 
* add basics for permanent locked vesting account support

* remove sdk.Msg support for PermanentLockedVestingAccount

* add tests for PermanentLockedVestingAccount

* remove unecessary tests

* drop unecessary create vesting acct msgs

* Update x/auth/vesting/types/vesting_account.go

Co-authored-by: Aaron Craelius <[email protected]>

* Update x/auth/vesting/types/vesting_account.go

Co-authored-by: Aaron Craelius <[email protected]>

* Update x/auth/vesting/types/vesting_account.go

Co-authored-by: Aaron Craelius <[email protected]>

* Update x/auth/vesting/types/vesting_account_test.go

Co-authored-by: Aaron Craelius <[email protected]>

* Review changes

* Factorize init function

* Factorize more

* Comments

* Fix build after rename

Co-authored-by: Amaury <[email protected]>
Co-authored-by: Aaron Craelius <[email protected]>
@sunnya97 @ahmedaly113
Add hooks to governance actions (#9133)
bffcae5 
* add governance hooks

* fix lint

* fix lint

* CHANGELOG

* sh -> gh

* improve comments

* add test

* add more tests

* rename two of the hooks

Co-authored-by: ahmedaly113 <[email protected]>
@odeke-em
crypto/types: check for overflow and unreasonably large element count (…
417832f 
…#9163)

Ensure that we don't pass overflowed values into make, because
a clever attacker could see that to cause:

    (bits+7)/8

to become negative, they just have to make (bits+7) become negative
simply by >=maxint-6

but also reject unreasonably large element count like >2**32, which
while arbitrary is super duper large for a bit array.

Fixes #9162
@dependabot
build(deps): bump github.com/prometheus/common from 0.20.0 to 0.21.0 (#…
1a15412 
…9167)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.20.0 to 0.21.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.20.0...v0.21.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@okwme
Proposal for expanding the ADR committee
f99b7b1 
Conversation in the gaia discord seems to merit an update to the ADR committee. I haven't spoken to any of the individuals to confirm their interest or availability but I'd like to use this as a more productive forum to push the conversation further. Especially looking for comment from those proposed (@marbar3778 @ebuchman @robert-zaremba @AmauryM @zmanian @sunnya97 @fedekunze @odeke-em  )
@cuonglm
types: make NewDecFromStr returns error for too large decimal (#9157)
e28271b 
Otherwise, NewDecFromStr may accept very large input, causing Dec
methods panic, e.g Dec.TruncateInt

Found by oss-fuzz: https://oss-fuzz.com/testcase-detail/6454129938530304

Fixes #9160
@okwme
Update CONTRIBUTING.md
f572523
@okwme
Update CONTRIBUTING.md
e1bd6cf 
Co-authored-by: Alessio Treglia <[email protected]>
Update README.md (#9181)
5ea817a 
the getting started link is busted, how about we send folks to Starport? and fix a few minor editorial nits
@aaronc @atheeshp
Make integration test suites reusable by apps (#6711)
3c65c3d 
* WIP on refactoring new integration tests.

* godocs

* godocs

* Fix ineff assign

* Updates

* Updates

* fix test

* refactor crisis, distr testsuites

* fix import issue

* refactor x/auth

* refactor x/authz

* refactor x/evidence

* refactor x/feegrant

* refactor x/genutil

* refactor x/gov

* refactor x/mint

* refactor x/params

* refactor x/{auth_vesting, slashing, staking}

* fix lint

* fix tests & lint

* fix lint

* fix tests

* lint

* lint

* fix lint memory

* add missing `norace` build flag

* update feegrant cfg

* fix lint

Co-authored-by: atheesh <[email protected]>
Co-authored-by: atheeshp <[email protected]>
@dependabot @fedekunze
build(deps): bump github.com/armon/go-metrics from 0.3.6 to 0.3.7 (#9187
1f78008 
)

Bumps [github.com/armon/go-metrics](https://github.com/armon/go-metrics) from 0.3.6 to 0.3.7.
- [Release notes](https://github.com/armon/go-metrics/releases)
- [Commits](hashicorp/go-metrics@v0.3.6...v0.3.7)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <[email protected]>
@dependabot
build(deps): bump github.com/grpc-ecosystem/go-grpc-middleware (#9186)
7c8ff2d 
Bumps [github.com/grpc-ecosystem/go-grpc-middleware](https://github.com/grpc-ecosystem/go-grpc-middleware) from 1.2.2 to 1.3.0.
- [Release notes](https://github.com/grpc-ecosystem/go-grpc-middleware/releases)
- [Changelog](https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/CHANGELOG.md)
- [Commits](grpc-ecosystem/go-grpc-middleware@v1.2.2...v1.3.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tac0turtle
remove docs deployment (#9202)
338dac4
@colin-axner @tac0turtle
@amaury1093 @mergify
remove IBC ADRs (#9191)
556134c 
* remove IBC ADRs

* remove ADR references from README

Co-authored-by: Marko <[email protected]>
Co-authored-by: Amaury <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@robert-zaremba @tac0turtle @amaury1093
setup: reuses proto container (#9192)
71b7fb8 
* setup: reuses proto container

* push docker image

* set image name

* revert and use latest

Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Amaury <[email protected]>
@okwme
Update CONTRIBUTING.md
8de11ba 
Co-authored-by: Alessio Treglia <[email protected]>
@okwme
Update .github/CODEOWNERS
3530299 
Co-authored-by: Alessio Treglia <[email protected]>
@okwme
Merge branch 'master' into okwme-adr-committee
3e8b5ca
@okwme
Update CONTRIBUTING.md
985b901 
removed secondary entirely
@okwme
Update CODEOWNERS
03eac1e
@okwme
Merge pull request #9169 from cosmos/okwme-adr-committee
9f835e7 
Proposal for expanding the ADR committee
@odeke-em
crypto/types: fix negative index accesses in CompactUnmarshal,GetInde…
49bf077 
…x,SetIndex (#9196)

Fixes unchecked negative index access that'd cause panics, in CompactBitArray's:
* CompactUnmarshal, which blindly used the result of binary.Uvarint
* GetIndex
* SetIndex

Fixes #9164
Fixes #9165
RiccardoM and others added 9 commits April 26, 2021 18:33
@RiccardoM
Fixed the --recover flag not working properly inside the init command (…
fdbc32e 
…#9201)

Co-authored-by: Alessio Treglia <[email protected]>
@atheeshp @blushi
x/feegrant simulation audit changes (#9145)
fc256a3 
* simulation genesis changes

* update msg types

* refactor

* update operations test

* fix sims

* fix tests

* fix tests

* address review changes

Co-authored-by: Marie Gauthier <[email protected]>

Co-authored-by: Marie Gauthier <[email protected]>
@blushi
x/feegrant completeness audit updates (#9177)
3ab1bc2 
* Updates to Genesis

* Move grpc_query tests to keeper pkg

* Unify CLI command usage message

* Use timestamp for time based expiration in cli

* Update FlagExpiration

* Update wording

* Add test case for invalid expiration

* Update cli Long description

* Update exp date examples

* Use constants
@aaronc @clevinson
@amaury1093 @fedekunze
Add labeler action (#9204)
e8e5c08 
* Add labeler action

* Update .github/labeler.yml

Co-authored-by: Amaury <[email protected]>

* Update .github/labeler.yml

Co-authored-by: Cory <[email protected]>

* update labels

* update labels

* Update .github/labeler.yml

Co-authored-by: Federico Kunze <[email protected]>

* update labels

Co-authored-by: Cory <[email protected]>
Co-authored-by: Amaury <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
@devashishdxt @tac0turtle @amaury1093
Add more details in error message for invalid vote option (#9185)
15edf3c 
Co-authored-by: Marko <[email protected]>
Co-authored-by: Amaury <[email protected]>
@tac0turtle
remove unused list (#9219)
f32597e
@colin-axner @tac0turtle
update contributor docs (#9190)
f45838f 
* update contributor docs

* revert changes to release section

* fix formatting

Co-authored-by: Marko <[email protected]>
@technicallyty @blushi @aleem1314
x/feegrant audit: clean up / add test coverage to types package (#9193)
0cbed20 
* Squashed commit of the following:

commit 58dc50051226a9eeb8d0ebea5bb0908fe5b9637f
Author: technicallyty <[email protected]>
Date:   Fri Apr 23 15:09:27 2021 -0700

    remove comments

commit a84107e1b3eaa31324cb0f4f097b49f02af79c69
Author: technicallyty <[email protected]>
Date:   Fri Apr 23 15:02:41 2021 -0700

    add tests for msgs.go

commit 2ad16869237e9631b402c93cde650c3fc554daf2
Author: technicallyty <[email protected]>
Date:   Fri Apr 23 13:20:21 2021 -0700

    specify test name

commit b7121277c9be586a7c80d010ec401e50b510e02a
Merge: c0c134d971 3c65c3d
Author: technicallyty <[email protected]>
Date:   Fri Apr 23 12:54:55 2021 -0700

    Merge branch 'master' into ty-9115-types_tests

commit c0c134d97107194dc4f9d3c501a15d023ae083e5
Author: technicallyty <[email protected]>
Date:   Thu Apr 22 19:59:11 2021 -0700

    -add test case to cli_test.go for filtered fee
    -clean up identifiers
    -remove redundant import alias from filtered_fee.go

commit f7ab3699da39be3ab886f96962d28d23438d2e8e
Author: technicallyty <[email protected]>
Date:   Thu Apr 22 09:57:31 2021 -0700

    remove unecessary constant

commit 9db59a82a7337cf5a7a3569c6900a44a6c81e8b4
Merge: a3e75ceb8a e28271b
Author: technicallyty <[email protected]>
Date:   Thu Apr 22 09:19:20 2021 -0700

    Merge branch 'master' into ty-9115-types_tests

commit a3e75ceb8a510ad9db43dd96073c43b7a8b062b0
Merge: 4d3dafab85 bffcae5
Author: technicallyty <[email protected]>
Date:   Wed Apr 21 12:04:39 2021 -0700

    Merge branch 'master' into ty-9115-types_tests

commit 4d3dafab85d85526a7c94b045289605289ee6b0d
Author: technicallyty <[email protected]>
Date:   Wed Apr 21 12:03:41 2021 -0700

    cleanup id's / add test case

commit e8f6924931ba95e592bfc3057ba167700458da41
Author: technicallyty <[email protected]>
Date:   Wed Apr 21 10:55:29 2021 -0700

    add test for 0 allowance / remove unused field on exp test

commit 516b6ef89a4582ad681cc6c5c101cf50a9a54fb5
Author: technicallyty <[email protected]>
Date:   Tue Apr 20 15:22:48 2021 -0700

    make names more clear, remove unused field

* fix imports

* fix tests

* rename test field

Co-authored-by: technicallyty <[email protected]>
Co-authored-by: Marie Gauthier <[email protected]>
Co-authored-by: MD Aleem <[email protected]>
@aleem1314 @blushi
x/feegrant state machine audit updates (#9176)
a2911d0 
* replace panic with error

* improve test coverage

* add time based tests to basic-fee

* add periodic fee tests

* wip

* add msg_server tests

* improve getFeeGrant

* fix failing test

* fix test

* fix comments

* refactor

* review changes

* review changes

* fix errors

* Update x/feegrant/types/basic_fee_test.go

Co-authored-by: Marie Gauthier <[email protected]>

* review changes

Co-authored-by: Marie Gauthier <[email protected]>
@cyberbono3 cyberbono3 closed this Apr 28, 2021
@robert-zaremba robert-zaremba mentioned this pull request May 3, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.