feat!: support debug trace QueryResult #9576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
force-pushed
the
debug_query_result
branch
from
47ada97
to
fc4354e
Compare
yihuang
changed the title
yihuang
force-pushed
the
debug_query_result
branch
from
fc4354e
to
940a1f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #9576 +/- ##
===========================================
+ Coverage 35.48% 63.47% +27.98%
===========================================
Files 332 571 +239
Lines 32620 37521 +4901
===========================================
+ Hits 11575 23815 +12240
+ Misses 19819 11848 -7971
- Partials 1226 1858 +632
|
likhita-809
reviewed
Jun 25, 2021
There was a problem hiding this comment.
Everything looks good
can you update this branch with master @yihuang ?
alexanderbez
approved these changes
Jun 25, 2021
amaury1093
reviewed
Jun 28, 2021
CHANGELOG.md
Outdated
| @@ -41,6 +41,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * [\#9231](https://github.com/cosmos/cosmos-sdk/pull/9231) Remove redundant staking errors. | |||
| * [\#9205](https://github.com/cosmos/cosmos-sdk/pull/9205) Improve readability in `abci` handleQueryP2P | |||
| * [\#9314](https://github.com/cosmos/cosmos-sdk/pull/9314) Update Rosetta SDK to upstream's latest release. | |||
| * [\#9576](https://github.com/cosmos/cosmos-sdk/pull/9576) Add debug error message to query result when enabled | |||
There was a problem hiding this comment.
Could you move this to a Features subsection in the Unreleased section?
|
@yihuang any updates on this? |
yihuang
force-pushed
the
debug_query_result
branch
from
940a1f1
to
d13574c
Compare
sorry for the delay, done now. |
done |
likhita-809
approved these changes
Jul 8, 2021
amaury1093
changed the title
amaury1093
added
the
A:automerge
amaury1093
added a commit
that referenced
this pull request
Jul 8, 2021
amaury1093
added a commit
that referenced
this pull request
Jul 8, 2021
* add changelog entry fro 9432 * Move #9576 to api-breaking Co-authored-by: Amaury <[email protected]>
|
can we backport this to |
This was referenced Feb 9, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To let abci query response include more detailed error message with node started with
--trace.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change