Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --generate-only and --offline flags can use keyname. #9838

Merged
merged 10 commits into from
Aug 9, 2021

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Aug 3, 2021

Description

Closes: #9837
ref: #9407


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #9838 (33de583) into master (f479b51) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 33de583 differs from pull request most recent head 417dc0a. Consider uploading reports for the commit 417dc0a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9838      +/-   ##
==========================================
+ Coverage   63.45%   63.55%   +0.10%     
==========================================
  Files         568      568              
  Lines       53260    53372     +112     
==========================================
+ Hits        33795    33922     +127     
+ Misses      17543    17526      -17     
- Partials     1922     1924       +2     
Impacted Files Coverage Δ
client/context.go 59.37% <ø> (+3.16%) ⬆️
x/auth/client/testutil/suite.go 96.63% <100.00%> (+0.31%) ⬆️
client/keys/import.go 57.14% <0.00%> (-1.95%) ⬇️
client/keys/add.go 67.42% <0.00%> (ø)
store/types/pruning.go 51.85% <0.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/bank/types/balance.go 89.83% <0.00%> (+3.46%) ⬆️
client/keys/export.go 73.21% <0.00%> (+8.92%) ⬆️

@orijbot
Copy link

orijbot commented Aug 5, 2021

@atheeshp atheeshp changed the title fix: --generate-only and --offline flags can use keyname. feat: --generate-only and --offline flags can use keyname. Aug 5, 2021
@atheeshp atheeshp marked this pull request as ready for review August 5, 2021 12:25
@atheeshp atheeshp requested a review from ebuchman August 5, 2021 12:26
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, can you add a changelog entry

x/auth/client/testutil/suite.go Show resolved Hide resolved
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 9, 2021
@mergify mergify bot merged commit 5f960b7 into master Aug 9, 2021
@mergify mergify bot deleted the atheesh/gen-only-can-use-name branch August 9, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using --offline and --generate-only the key names are no longer recognized, have to use an address
5 participants