Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix truffle migrate issue, return 0 nonce if account doesn't exist #345

Merged
merged 4 commits into from
Jun 26, 2020

Conversation

noot
Copy link
Contributor

@noot noot commented Jun 26, 2020

Closes: #305

Description

  • fix "account does not exist" error in eth_getTransactionCount
  • see test instructions in issue

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@noot noot changed the title [wip] fix truffle migrate issue fix truffle migrate issue, return 0 nonce if account doesn't exist Jun 26, 2020
@noot noot marked this pull request as ready for review June 26, 2020 17:33
@noot noot self-assigned this Jun 26, 2020
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @noot 🙂

CHANGELOG.md Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit e9c494c into development Jun 26, 2020
@fedekunze fedekunze deleted the noot/truffle branch June 26, 2020 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

truffle migrate not working
2 participants