Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Justin/rpc #558

Merged
merged 23 commits into from
Oct 1, 2020
Merged

Justin/rpc #558

merged 23 commits into from
Oct 1, 2020

Conversation

J-Thompson12
Copy link
Contributor

Closes: #551
Closes: #553

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

docs/.vuepress/config.js Outdated Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit 3ed790b into development Oct 1, 2020
@fedekunze fedekunze deleted the justin/rpc branch October 1, 2020 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link anchor on rpc docs doenst work "Found a bug link doesn't work" on docs
2 participants