Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

geth update to 1.9.24 #594

Merged
merged 10 commits into from
Nov 16, 2020
Merged

geth update to 1.9.24 #594

merged 10 commits into from
Nov 16, 2020

Conversation

noot
Copy link
Contributor

@noot noot commented Nov 12, 2020

Closes: #XXX

Description

  • updates to geth 1.9.24

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@noot noot requested a review from fedekunze as a code owner November 12, 2020 20:50
@noot noot changed the title Noot/geth update geth update to 1.9.24 Nov 12, 2020
@noot noot requested a review from araskachoi November 12, 2020 20:50
@noot noot self-assigned this Nov 12, 2020
x/evm/types/chain_config.go Show resolved Hide resolved
x/evm/types/chain_config.go Show resolved Hide resolved
@@ -243,6 +243,22 @@ func (csdb *CommitStateDB) SubRefund(gas uint64) {
csdb.refund -= gas
}

// AddAddressToAccessList is currently unimplemented
func (csdb *CommitStateDB) AddAddressToAccessList(_ ethcmn.Address) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add this functionality since it is used for supporting EIP2929. I think there are additional journal entries too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I'll work on implementing it

@noot noot requested a review from fedekunze November 13, 2020 18:00
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iterating over maps causes non-determinism on the app. Let's use slices instead

x/evm/types/access_list.go Outdated Show resolved Hide resolved
x/evm/types/access_list.go Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit 2796f55 into development Nov 16, 2020
@fedekunze fedekunze deleted the noot/geth-update branch November 16, 2020 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants