Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix incorrect blockHash in evm #780

Merged
merged 8 commits into from
Mar 19, 2021
Merged

Conversation

summerpro
Copy link
Contributor

Closes: #775

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@summerpro summerpro marked this pull request as draft February 8, 2021 13:27
@summerpro summerpro marked this pull request as ready for review February 9, 2021 11:12
x/evm/keeper/abci.go Outdated Show resolved Hide resolved
@summerpro summerpro requested a review from noot February 13, 2021 06:24
@summerpro summerpro changed the title incorrect blockHash fix incorrect blockHash in evm Feb 17, 2021
@zhongqiuwood
Copy link

zhongqiuwood commented Feb 17, 2021

The PR fixed:
The solidity globally Variable [blockhash] does not work

blockhash(uint blockNumber) returns (bytes32): hash of the given block - only works for 256 most recent, excluding current, blocks

@araskachoi araskachoi merged commit 75fb3cc into cosmos:development Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MisUse of headHash as blockHash when create EVM context
4 participants