refactor: update comments on globalfee, genutil module init order (#2494

)

* docs: update comments on globalfee, genutil module init order

* rename GlobalMinFee GlobalMinFeeParamSource in FeeDecorator

* fix: deadlink

app/modules.go

@@ -60,27 +60,16 @@ import (
 )
 
 var maccPerms = map[string][]string{
-<<<<<<< HEAD
 	authtypes.FeeCollectorName:     nil,
 	distrtypes.ModuleName:          nil,
 	icatypes.ModuleName:            nil,
 	minttypes.ModuleName:           {authtypes.Minter},
 	stakingtypes.BondedPoolName:    {authtypes.Burner, authtypes.Staking},
 	stakingtypes.NotBondedPoolName: {authtypes.Burner, authtypes.Staking},
 	govtypes.ModuleName:            {authtypes.Burner},
-	ibctransfertypes.ModuleName:    {authtypes.Minter, authtypes.Burner},
-=======
-	authtypes.FeeCollectorName:        nil,
-	distrtypes.ModuleName:             nil,
-	icatypes.ModuleName:               nil,
-	minttypes.ModuleName:              {authtypes.Minter},
-	stakingtypes.BondedPoolName:       {authtypes.Burner, authtypes.Staking},
-	stakingtypes.NotBondedPoolName:    {authtypes.Burner, authtypes.Staking},
-	govtypes.ModuleName:               {authtypes.Burner},
-	liquiditytypes.ModuleName:         {authtypes.Minter, authtypes.Burner},
+	// liquiditytypes.ModuleName:         {authtypes.Minter, authtypes.Burner},
 	ibctransfertypes.ModuleName:       {authtypes.Minter, authtypes.Burner},
 	providertypes.ConsumerRewardsPool: nil,
->>>>>>> 82b71bb65 (fix!: revert to ICS v1.1.0-multiden (#2559))
 }
 
 // ModuleBasics defines the module BasicManager is in charge of setting up basic,
@@ -299,6 +288,14 @@ func orderInitBlockers() []string {
 		paramstypes.ModuleName,
 		upgradetypes.ModuleName,
 		vestingtypes.ModuleName,
+		// The globalfee module should ideally be initialized before the genutil module in theory:
+		// The globalfee antehandler performs checks in DeliverTx, which is called by gentx.
+		// When the global fee > 0, gentx needs to pay the fee. However, this is not expected,
+		// (in our case, the global fee is initialized with an empty value, which might not be a problem
+		// if the globalfee in genesis is not changed.)
+		// To resolve this issue, we should initialize the globalfee module after genutil, ensuring that the global
+		// min fee is empty when gentx is called.
+		// For more details, please refer to the following link: https://github.com/cosmos/gaia/issues/2489
 		// globalfee.ModuleName,
 		providertypes.ModuleName,
 		consensusparamtypes.ModuleName,

go.mod

@@ -14,7 +14,7 @@ require (
 	github.com/cosmos/interchain-security v1.0.1-0.20230522154154-1bb8d39e691a
 	cosmossdk.io/math v1.0.1
 	github.com/cosmos/go-bip39 v1.0.0
-	github.com/cosmos/interchain-security v1.1.1
+	github.com/cosmos/interchain-security v1.1.1-multiden
 	github.com/golang/protobuf v1.5.3
 	github.com/golangci/golangci-lint v1.52.2
 	github.com/gorilla/mux v1.8.0
@@ -259,6 +259,7 @@ require (
 	github.com/t-yuki/gocover-cobertura v0.0.0-20180217150009-aaee18c8195c // indirect
 	github.com/tdakkota/asciicheck v0.2.0 // indirect
 	github.com/tendermint/go-amino v0.16.0 // indirect
+	github.com/tendermint/spm v0.1.9 // indirect
 	github.com/tetafro/godot v1.4.11 // indirect
 	github.com/tidwall/btree v1.6.0 // indirect
 	github.com/timakin/bodyclose v0.0.0-20221125081123-e39cf3fc478e // indirect
@@ -277,7 +278,6 @@ require (
 	go.etcd.io/bbolt v1.3.7 // indirect
 	go.opencensus.io v0.24.0 // indirect
 	go.uber.org/atomic v1.10.0 // indirect
-	go.uber.org/goleak v1.1.12 // indirect
 	go.uber.org/multierr v1.8.0 // indirect
 	go.uber.org/zap v1.24.0 // indirect
 	golang.org/x/crypto v0.7.0 // indirect