WIP: Rho #1436

okwme · 2022-04-19T10:31:48Z

replaces #1410

okwme · 2022-04-19T10:32:56Z

I took the work that Lido began on their fork of wasmd and started porting it over to gaia. I did this by pasting the entirety of each file from theirs to ours, then went through the git diff and added or tweaked as seemed resonable. Some TODOs still left to confirm certain things.

Updated the go.mod similarly and did a replace on github.com/CosmWasm/wasmd with github.com/cosmos/wasmd to use the latest commit from their working branch.

There are still a number of errors, but most of them seem to be around importing liquidity module and other sdk v0.45 discrepancies.

I started this with a new branch off of Theta-main, that might not have been right now that it's merged into main. Unfortunately when I target main there are over 100 files changed. Would rebasing main fix that?

…me/rho-base-main

…into okwme/rho-base-main

alexanderbez

Reviewed the E2E changes -- mainly a few minor remarks.

Looking into the liveness test...

alexanderbez · 2022-04-26T20:23:35Z

tests/e2e/e2e_setup_test.go

+		if err != nil {
+			s.Require().NoError(err)
+		}


Suggested change

if err != nil {

s.Require().NoError(err)

}

s.Require().NoError(err)

alexanderbez · 2022-04-26T20:23:57Z

tests/e2e/e2e_setup_test.go

 		s.Require().NoError(
-			addGenesisAccount(val0ConfigDir, "", initBalanceStr, val.keyInfo.GetAddress()),
+			addGenesisAccount(val0ConfigDir, "", initBalanceStr, address),
 		)


no need to make this multi-line :)

tests/e2e/e2e_test.go

tests/e2e/keys.go

alexanderbez · 2022-04-26T20:25:19Z

tests/e2e/keys.go

-	kb, err := keyring.New("testnet", keyring.BackendMemory, "", nil)
+func createMemoryKeyFromMnemonic(mnemonic string) (*keyring.Record, error) {
+
+	cdc := params.MakeTestEncodingConfig().Codec


There should already be a private global for the codec -- let's use that instead of creating a new variable here.

ah that's great! how do i access it?

alexanderbez · 2022-04-26T20:25:30Z

tests/e2e/validator.go

 	v.consensusKey = filePV.Key

 	return nil
 }

 func (v *validator) createKeyFromMnemonic(name, mnemonic string) error {
-	kb, err := keyring.New(keyringAppName, keyring.BackendTest, v.configDir(), nil)
+	cdc := params.MakeTestEncodingConfig().Codec


alexanderbez · 2022-04-26T20:27:54Z

Liveness test fails due to the image failing to build: https://github.com/cosmos/gaia/runs/6182913797?check_suite_focus=true#step:5:176

I can look into this shortly.

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

okwme · 2022-04-27T11:28:51Z

Liveness test fails due to the image failing to build: https://github.com/cosmos/gaia/runs/6182913797?check_suite_focus=true#step:5:176

I can look into this shortly.

that's weird, it builds locally with make build but fails when i run make localnet-start

okwme · 2022-04-27T11:33:04Z

ah this is the error:

> make localnet-start
--> Ensure dependencies have not been modified
LEDGER_ENABLED=false GOOS=linux GOARCH=amd64 /Library/Developer/CommandLineTools/usr/bin/make build
--> Ensure dependencies have not been modified
go build -mod=readonly -tags "netgo" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=gaia -X github.com/cosmos/cosmos-sdk/version.AppName=gaiad -X github.com/cosmos/cosmos-sdk/version.Version=okwme/rho-base-main-b83b0b85b8092061d32c6dd4029434da6ee85458 -X github.com/cosmos/cosmos-sdk/version.Commit=b83b0b85b8092061d32c6dd4029434da6ee85458 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo" -X github.com/tendermint/tendermint/version.TMCoreSemVer=v0.36.0-dev.0.20220226000315-ea497301a7d3 -w -s' -trimpath -o /Users/billy/GitHub/cosmos/gaia/build/ ./...
# github.com/CosmWasm/wasmvm/api
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mock_failure.go:15:27: undefined: GoAPI
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:192:2: undefined: GasMeter
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:193:20: undefined: Gas
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:197:11: undefined: Gas
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:198:11: undefined: Gas
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:202:28: undefined: Gas
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:209:38: undefined: Gas
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:213:32: undefined: Gas
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:227:42: undefined: Gas
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:362:20: undefined: GoAPI
../../../go/pkg/mod/github.com/!cosm!wasm/[email protected]/api/mocks.go:362:20: too many errors
make[1]: *** [build] Error 2

Looks like it's because https://github.com/CosmWasm/wasmvm has tests that mock wasmd. Our version of wasmd is updated to v0.46 but I'm guessing the mocks in wasmvm are still targeting an older version of the SDK.

Is it possible to disable these somehow? We went a route with forking wasmd so that we wouldn't have to fork wasmvm as well and it would be great if we still didn't need to.

alexanderbez · 2022-04-27T13:05:47Z

Liveness tests refactored -> #1456

yaruwangway · 2022-05-02T14:00:45Z

hi, is this branch working, it seems have some problem with importing packet-forwarding package, it imports the fork, but the fork still has the module name with strangelove-ventures @okwme

okwme · 2022-05-02T14:24:10Z

@yaruwangway working on fixing conflicts now

okwme · 2022-05-12T10:55:43Z

closing in favor of #1478

base updates from lido wasmd repo

e2fb0ff

okwme requested review from alexanderbez, zmanian, yaruwangway, jgimeno, crodriguezvega, cmwaters, jackzampolin, mmulji-ic, glnro and tokamak-git as code owners April 19, 2022 10:31

okwme marked this pull request as draft April 19, 2022 10:31

okwme mentioned this pull request Apr 19, 2022

WIP: Rho base #1410

Closed

okwme added 12 commits April 19, 2022 12:40

Merge branch 'main' into okwme/rho-base-main

d1a814f

tweaks to tm version, remove ante feature, remove g-dex (liquidity)

4dfa202

go.sum

c08b8df

Merge branch 'main' into okwme/rho-base-main

cf4e9a5

Merge branch 'main' into okwme/rho-base-main

03a357c

latest changes from lido

ca1ed5a

Merge branch 'okwme/rho-base-main' of github.com:cosmos/gaia into okw…

049c12a

…me/rho-base-main

almost

f58c0e5

almost

fd74997

go mod tidy works;

f82ac89

Merge branch 'main' into okwme/rho-base-main

f7c8618

Merge branch 'main' into okwme/rho-base-main

880ea98

okwme mentioned this pull request Apr 26, 2022

Update to v0.46 strangelove-ventures/packet-forward-middleware#21

Closed

okwme added 3 commits April 26, 2022 11:59

fixed e2e tendermint import error

ce736e0

Merge branch 'okwme/rho-base-main' of github.com:cosmos/gaia into okw…

393b8c4

…me/rho-base-main

swuashing errors

e306e53

okwme added 4 commits April 26, 2022 18:01

no build errors

15f9d22

Merge branch 'main' into okwme/rho-base-main

7e36ec6

remove venv files

f7265b0

Merge branch 'okwme/rho-base-main' of https://github.com/cosmos/gaia …

b83b0b8

…into okwme/rho-base-main

alexanderbez suggested changes Apr 26, 2022

View reviewed changes

okwme and others added 2 commits April 27, 2022 13:26

Update tests/e2e/e2e_test.go

be93e25

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

Update tests/e2e/keys.go

0346e7a

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

adizere mentioned this pull request Apr 28, 2022

Investigate new event structure of tendermint-go v0.35 informalsystems/hermes#1560

Closed

8 tasks

okwme and others added 3 commits May 2, 2022 18:26

comment out packet-forward-middleware

27fbae7

cherrypicked refactor: liveness tests

563cbf0

gaia module v7 to v8

491ed2c

okwme mentioned this pull request May 11, 2022

Rho Base #1478

Merged

okwme closed this May 12, 2022

okwme deleted the okwme/rho-base-main branch May 12, 2022 10:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Rho #1436

WIP: Rho #1436

okwme commented Apr 19, 2022

okwme commented Apr 19, 2022

alexanderbez left a comment

alexanderbez Apr 26, 2022

alexanderbez Apr 26, 2022

alexanderbez Apr 26, 2022

okwme Apr 27, 2022

alexanderbez Apr 26, 2022

alexanderbez commented Apr 26, 2022 •

edited

Loading

okwme commented Apr 27, 2022

okwme commented Apr 27, 2022

alexanderbez commented Apr 27, 2022

yaruwangway commented May 2, 2022 •

edited

Loading

okwme commented May 2, 2022

okwme commented May 12, 2022

WIP: Rho #1436

WIP: Rho #1436

Conversation

okwme commented Apr 19, 2022

okwme commented Apr 19, 2022

alexanderbez left a comment

Choose a reason for hiding this comment

alexanderbez Apr 26, 2022

Choose a reason for hiding this comment

alexanderbez Apr 26, 2022

Choose a reason for hiding this comment

alexanderbez Apr 26, 2022

Choose a reason for hiding this comment

okwme Apr 27, 2022

Choose a reason for hiding this comment

alexanderbez Apr 26, 2022

Choose a reason for hiding this comment

alexanderbez commented Apr 26, 2022 • edited Loading

okwme commented Apr 27, 2022

okwme commented Apr 27, 2022

alexanderbez commented Apr 27, 2022

yaruwangway commented May 2, 2022 • edited Loading

okwme commented May 2, 2022

okwme commented May 12, 2022

alexanderbez commented Apr 26, 2022 •

edited

Loading

yaruwangway commented May 2, 2022 •

edited

Loading