Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade module #196

Merged
merged 8 commits into from
Nov 30, 2019
Merged

Upgrade module #196

merged 8 commits into from
Nov 30, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Nov 19, 2019 •
edited by alexanderbez
Loading

Replaces #184

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

ethanfrey and others added 2 commits November 19, 2019 14:41
@ethanfrey @fedekunze
Gaia upgrade demo (#184)
e8db770 
* integrate upgrade in app.go

* integrated gaia with upgrade

* Update deps to point to regen/upgrade-modules pr

* added docs for upgrade-demo

* Complete upgrade-demo docs, app cleanup

* Update go.mod to most recent

* Moved the demo upgrade handler from app.go into demo docs
@fedekunze
move update demo to migration docs; cleanup demo and make it more gen…
ccda477 
…eral
@fedekunze fedekunze added the status: blocked Blocked by an external issue. label Nov 19, 2019
@fedekunze
Copy link
Collaborator Author

I want to block this until we add the upgrade module on the SDK's simapp.

@alexanderbez
Copy link
Contributor

Why is that @fedekunze? There is nothing to simulate really. If anything, simulation will short-circuit prematurely if an upgrade proposal passes.

@fedekunze fedekunze removed the status: blocked Blocked by an external issue. label Nov 22, 2019
@fedekunze fedekunze marked this pull request as ready for review November 22, 2019 13:16
@fedekunze fedekunze added the R4R label Nov 22, 2019
alexanderbez
alexanderbez approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated & tested. ACK.

@alexanderbez alexanderbez merged commit 9823769 into master Nov 30, 2019
@alexanderbez alexanderbez deleted the fedekunze/upgrade-module branch November 30, 2019 17:45
@jackzampolin
Copy link
Member

Huge merge! Very excited to see this live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fedekunze @alexanderbez @jackzampolin @ethanfrey