Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update against sdk's keys commands changes #211

Merged
merged 4 commits into from
Dec 5, 2019
Merged

Update against sdk's keys commands changes #211

merged 4 commits into from
Dec 5, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Dec 5, 2019

Ref: cosmos/cosmos-sdk#5366

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added the R4R label Dec 5, 2019
@alessio alessio added the scope: CLI Issues and features pertaining to Gaia's CLI client. label Dec 5, 2019
alexanderbez
alexanderbez approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alexanderbez
alexanderbez reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something wrong with CI @alessio?

@alexanderbez alexanderbez merged commit 39b5d48 into master Dec 5, 2019
@alexanderbez alexanderbez deleted the alessio/keys-delete-all branch December 5, 2019 17:55
@jackzampolin jackzampolin restored the alessio/keys-delete-all branch December 5, 2019 22:35
@alessio alessio deleted the alessio/keys-delete-all branch December 12, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
scope: CLI Issues and features pertaining to Gaia's CLI client.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio @alexanderbez