chore: Fix makefile linting targets #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glnro
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
jtremback,
mpoke,
sainoe,
MSalopek and
shaspitz
as code owners
sainoe
approved these changes
Apr 6, 2023
mpoke
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Is it necessary to update .golangci.yml?
There was a problem hiding this comment.
What updates would you want to make to .golangci.yml ? This PR is specific to updating the makefile linting targets, not changing anything about golangci configuration.
| @go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version) | ||
| @$(golangci_lint_cmd) run --timeout=10m | ||
|
|
||
| lint-fix: |
There was a problem hiding this comment.
What's the difference between make lint-fix and make format?
There was a problem hiding this comment.
make lint-fix is just running the golanci linter, while make format is running gofumpt on everything that's not excluded by -not -path, and then it runs golanci linter afterwards.
mpoke
approved these changes
Apr 12, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
(cherry picked from commit 53397fa)
mpoke
pushed a commit
that referenced
this pull request
Apr 12, 2023
(cherry picked from commit 53397fa) Co-authored-by: lg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Makefile linting targets to be consistent with the Cosmos SDK