Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: move BypassMinFeeMsgTypes and MaxTotalBypassMinFeeMsgGasUsage to params #2424

Merged
merged 59 commits into from
May 12, 2023

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Apr 20, 2023

Description

Add BypassMinFeeMsgTypes and MaxTotalBypassMinFeeMsgGasUsage to the GlobalFee params.
The AnteHandler is now accessing these values from the paramstore instead of the app.toml config file.

This PR partially closes #2366 and doesn't contain the migration and the config refactoring work which will be addressed by
these two PRs: #2352 #2369.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

tests/e2e/query.go Outdated Show resolved Hide resolved
tests/e2e/query.go Outdated Show resolved Hide resolved
"mixed valid and invalid msgs, fail": {
[]string{
"/ibc.core.channel.v1.MsgRecvPacket",
"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just use the invalid example from above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't the same. A leading "/" is missing in the msg-type above.

@sainoe sainoe requested review from mmulji-ic and mpoke May 5, 2023 12:38
tests/e2e/e2e_bypassminfee_test.go Outdated Show resolved Hide resolved
x/globalfee/ante/fee.go Show resolved Hide resolved
x/globalfee/ante/fee.go Show resolved Hide resolved
x/globalfee/types/params.go Show resolved Hide resolved
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval.

Please update #2352 and #2369 when this gets merged. I see some merge conflicts there

@yaruwangway yaruwangway merged commit a0cd727 into main May 12, 2023
@yaruwangway yaruwangway deleted the sainoe/global-fee-params branch May 12, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move bypassMinFeeMsgTypes and MaxTotalBypassMinFeeMsgGasUsage to params
8 participants