Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: move Global Fee checks to DeliverTx #2447

Merged
merged 36 commits into from
May 10, 2023

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented May 1, 2023

Update AnteHandler to impose the Global Fee min gas prices in DeliverTx mode.

Please note: this PR also contains some refactor of the fee logic for easy reading.

Closes: #2383


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #2447 (952d3ff) into main (26dcfae) will increase coverage by 0.47%.
The diff coverage is 98.24%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2447      +/-   ##
==========================================
+ Coverage   84.14%   84.62%   +0.47%     
==========================================
  Files          22       22              
  Lines        1533     1541       +8     
==========================================
+ Hits         1290     1304      +14     
+ Misses        195      191       -4     
+ Partials       48       46       -2     
Impacted Files Coverage Δ
x/globalfee/ante/fee.go 90.44% <97.77%> (+5.16%) ⬆️
x/globalfee/ante/fee_utils.go 100.00% <100.00%> (ø)

CHANGELOG.md Show resolved Hide resolved
tests/e2e/e2e_exec_test.go Outdated Show resolved Hide resolved
tests/e2e/e2e_exec_test.go Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
x/globalfee/ante/fee.go Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
tests/e2e/e2e_exec_test.go Show resolved Hide resolved
x/globalfee/ante/fee.go Outdated Show resolved Hide resolved
x/globalfee/ante/fee.go Outdated Show resolved Hide resolved
x/globalfee/ante/fee.go Show resolved Hide resolved
x/globalfee/ante/fee.go Outdated Show resolved Hide resolved
x/globalfee/ante/fee.go Outdated Show resolved Hide resolved
x/globalfee/ante/fee.go Outdated Show resolved Hide resolved
@mpoke mpoke self-requested a review May 10, 2023 11:10
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@yaruwangway yaruwangway merged commit 79f5b83 into main May 10, 2023
@yaruwangway yaruwangway deleted the sainoe/global-fee-deliver-tx branch May 10, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execute fee check logic in deliverTX
4 participants