Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validate cmd to tx and query subcmds #347

Merged
merged 1 commit into from
Apr 6, 2020
Merged

add validate cmd to tx and query subcmds #347

merged 1 commit into from
Apr 6, 2020

Conversation

colin-axner
Copy link
Contributor

Closes: #310

Description

Adds validation to the usage of the tx and query commands.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@colin-axner colin-axner added R4R scope: CLI Issues and features pertaining to Gaia's CLI client. labels Apr 6, 2020
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 🌮

@alexanderbez
Copy link
Contributor

Not sure why setup-dependencies is stuck. I seem to have lost permissions in CircleCI. Maybe @alessio can give it another run?

@alessio alessio merged commit ce8dc8f into cosmos:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: CLI Issues and features pertaining to Gaia's CLI client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support "unknown command" for tx and query commands
4 participants