Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop error result from NewMutableTree/NewMutableTreeWithOpts #756

Closed
elias-orijtech opened this issue May 3, 2023 · 1 comment · Fixed by #777
Closed

Drop error result from NewMutableTree/NewMutableTreeWithOpts #756

elias-orijtech opened this issue May 3, 2023 · 1 comment · Fixed by #777

Comments

@elias-orijtech
Copy link
Contributor

Both constructors always return the nil error.

@odeke-em
@tac0turtle
Copy link
Member

want to submit a pr?

elias-orijtech added a commit to elias-orijtech/iavl that referenced this issue May 24, 2023
@elias-orijtech
refactor: don't return an error from NewImmutableTree[WithOpts]
5c14276 
Tree construction never fails, so don't return an error.

Fixes cosmos#756
@elias-orijtech elias-orijtech mentioned this issue May 24, 2023
Merged
elias-orijtech added a commit to elias-orijtech/iavl that referenced this issue May 25, 2023
@elias-orijtech
refactor: don't return an error from NewImmutableTree[WithOpts]
3b062fe 
Tree construction never fails, so don't return an error.

Fixes cosmos#756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Drop error results from functions that never fail elias-orijtech/iavl
2 participants
@tac0turtle @elias-orijtech