Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add logger #735

Merged
merged 5 commits into from
Apr 12, 2023
Merged

refactor: add logger #735

merged 5 commits into from
Apr 12, 2023

Conversation

tac0turtle
Copy link
Member

replace local logger with sdk one, this help sin the future when we add logs to the repo. We should avoid adding info logs here and mainly to error and debug if possible

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! We probably need a changelog that mentions the api break.

cmd/iaviewer/main.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle merged commit 85a123c into master Apr 12, 2023
@tac0turtle tac0turtle deleted the marko/add_logger branch April 12, 2023 12:50
@tac0turtle
Copy link
Member Author

@Mergifyio backport release/v1.x.x

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

backport release/v1.x.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 12, 2023
(cherry picked from commit 85a123c)

# Conflicts:
#	export_test.go
#	go.mod
#	go.sum
#	internal/logger/logger.go
tac0turtle added a commit that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants