review comment

cosmos · Mar 29, 2024 · 0e86b53 · 0e86b53
1 parent b7b48c5
commit 0e86b53
Showing 1 changed file with 22 additions and 18 deletions.
diff --git a/modules/apps/27-interchain-accounts/host/types/msgs_test.go b/modules/apps/27-interchain-accounts/host/types/msgs_test.go
@@ -107,15 +107,17 @@ func TestMsgModuleQuerySafeValidateBasic(t *testing.T) {
 	for _, tc := range testCases {
 		tc := tc
 
-		err := tc.msg.ValidateBasic()
-
-		expPass := tc.expErr == nil
-		if expPass {
-			require.NoError(t, err)
-		} else {
-			require.Error(t, err)
-			require.ErrorIs(t, err, tc.expErr)
-		}
+		t.Run(tc.name, func(t *testing.T) {
+			err := tc.msg.ValidateBasic()
+
+			expPass := tc.expErr == nil
+			if expPass {
+				require.NoError(t, err)
+			} else {
+				require.Error(t, err)
+				require.ErrorIs(t, err, tc.expErr)
+			}
+		})
 	}
 }
 
@@ -132,14 +134,16 @@ func TestMsgModuleQuerySafeGetSigners(t *testing.T) {
 	for _, tc := range testCases {
 		tc := tc
 
-		msg := types.NewMsgModuleQuerySafe(tc.address.String(), []*types.QueryRequest{})
-		encodingCfg := moduletestutil.MakeTestEncodingConfig(ica.AppModuleBasic{})
-		signers, _, err := encodingCfg.Codec.GetMsgV1Signers(msg)
-		if tc.expPass {
-			require.NoError(t, err)
-			require.Equal(t, tc.address.Bytes(), signers[0])
-		} else {
-			require.Error(t, err)
-		}
+		t.Run(tc.name, func(t *testing.T) {
+			msg := types.NewMsgModuleQuerySafe(tc.address.String(), []*types.QueryRequest{})
+			encodingCfg := moduletestutil.MakeTestEncodingConfig(ica.AppModuleBasic{})
+			signers, _, err := encodingCfg.Codec.GetMsgV1Signers(msg)
+			if tc.expPass {
+				require.NoError(t, err)
+				require.Equal(t, tc.address.Bytes(), signers[0])
+			} else {
+				require.Error(t, err)
+			}
+		})
 	}
 }