remove channel handshake commands

CHANGELOG.md

@@ -38,7 +38,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### API Breaking
 
-* (modules/core/03-connection) [\#109](https://github.com/cosmos/ibc-go/pull/109) Remove connection handshake CLI commands.
+* (modules/core) [\#109](https://github.com/cosmos/ibc-go/pull/109) Remove connection and channel handshake CLI commands.
 
 ### State Machine Breaking
 

modules/core/04-channel/client/cli/cli.go

@@ -45,14 +45,7 @@ func NewTxCmd() *cobra.Command {
 		RunE:                       client.ValidateCmd,
 	}
 
-	txCmd.AddCommand(
-		NewChannelOpenInitCmd(),
-		NewChannelOpenTryCmd(),
-		NewChannelOpenAckCmd(),
-		NewChannelOpenConfirmCmd(),
-		NewChannelCloseInitCmd(),
-		NewChannelCloseConfirmCmd(),
-	)
+	txCmd.AddCommand()
 
 	return txCmd
 }

testing/sdk_test.go

@@ -29,7 +29,6 @@ import (
 	dbm "github.com/tendermint/tm-db"
 
 	ibcclientcli "github.com/cosmos/ibc-go/modules/core/02-client/client/cli"
-	ibccli "github.com/cosmos/ibc-go/modules/core/04-channel/client/cli"
 	"github.com/cosmos/ibc-go/testing/simapp"
 )
 
@@ -202,6 +201,11 @@ func (s *IntegrationTestSuite) TestLegacyRestErrMessages() {
 		`{"@type":"/ibc.lightclients.solomachine.v1.ClientState","sequence":"1","frozen_sequence":"0","consensus_state":{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AtK50+5pJOoaa04qqAqrnyAqsYrwrR/INnA6UPIaYZlp"},"diversifier":"testing","timestamp":"10"},"allow_update_after_proposal":false}`,
 	)
 
+	badClientStateJSON := testutil.WriteToNewTempFile(
+		s.T(),
+		`{"@type":"/ibc.lightclients.solomachine.v1.ClientState","sequence":"1","frozen_sequence":"0","consensus_state":{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AtK50+5pJOoaa04qqAqrnyAqsYrwrR/INnA6UPIaYZlp"},"diversifier":"DIFFERENT","timestamp":"10"},"allow_update_after_proposal":false}`,
+	)
+
 	// Write consensus json to temp file, used for an IBC message.
 	// Generated by printing the result of cdc.MarshalIntefaceJSON on
 	// a solo machine consensus state
@@ -218,18 +222,18 @@ func (s *IntegrationTestSuite) TestLegacyRestErrMessages() {
 	}{
 		{
 			"Failing IBC message",
-			ibccli.NewChannelCloseInitCmd(),
+			ibcclientcli.NewCreateClientCmd(),
 			[]string{
-				"121",       // dummy port-id
-				"channel-0", // dummy channel-id
+				badClientStateJSON.Name(), // path to client state json
+				consensusJSON.Name(),      // path to consensus json,
 				fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
 				fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastBlock),
 				fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, sdk.NewInt(10))).String()),
 				fmt.Sprintf("--gas=%d", flags.DefaultGasLimit),
 				fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()),
 				fmt.Sprintf("--%s=foobar", flags.FlagMemo),
 			},
-			uint32(7),
+			uint32(8),
 		},
 		{
 			"Successful IBC message",