fixing bug with mutating state for comparision

cosmos · Mar 28, 2023 · fb9fad0 · fb9fad0
1 parent 5619334
commit fb9fad0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/modules/core/04-channel/keeper/upgrade.go b/modules/core/04-channel/keeper/upgrade.go
@@ -38,6 +38,7 @@ func (k Keeper) ChanUpgradeInit(
 		return 0, "", errorsmod.Wrapf(types.ErrChannelCapabilityNotFound, "caller does not own capability for channel, port ID (%s) channel ID (%s)", portID, channelID)
 	}
 
+	restoreChannel := channel
 	channel.State = types.INITUPGRADE
 	if reflect.DeepEqual(channel, proposedUpgradeChannel) {
 		return 0, "", errorsmod.Wrap(types.ErrChannelExists, "existing channel end is identical to proposed upgrade channel end")
@@ -66,7 +67,7 @@ func (k Keeper) ChanUpgradeInit(
 		TimeoutTimestamp: counterpartyTimeoutTimestamp,
 	}
 
-	k.SetUpgradeRestoreChannel(ctx, portID, channelID, channel)
+	k.SetUpgradeRestoreChannel(ctx, portID, channelID, restoreChannel)
 	k.SetUpgradeSequence(ctx, portID, channelID, upgradeSequence)
 	k.SetUpgradeTimeout(ctx, portID, channelID, upgradeTimeout)