Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetVersions from Connection interface #1689

Closed
3 tasks
Tracked by #1690
colin-axner opened this issue Jul 12, 2022 · 3 comments · Fixed by #2539
Closed
3 tasks
Tracked by #1690

Remove GetVersions from Connection interface #1689

colin-axner opened this issue Jul 12, 2022 · 3 comments · Fixed by #2539
Assignees
Labels
03-connection good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

Remove GetVersions from the connection interface.

Problem Definition

This function is unused as an interface. The only calls to this function use the concrete connection type. The connection interface only exists to avoid import cycles (we only use one concrete connection type).

Proposal

Remove GetVersions from the connection interface. Leave the function within the ConnectionEnd implementation. Please include a changelog entry. This change doesn't need to be backported


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces 03-connection labels Jul 12, 2022
@Daniyal98
Copy link
Contributor

Hello, I would like to start working on this one if it is still open

@crodriguezvega
Copy link
Contributor

Hello, I would like to start working on this one if it is still open

Yes, it's still available! Thanks very much for offering to pick it up. I will assign it to you now!

@Daniyal98
Copy link
Contributor

Thank you! I would start working on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03-connection good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

3 participants