Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daniyal/issue#1689 remove get versions #2539

Merged

Conversation

Daniyal98
Copy link
Contributor

@Daniyal98 Daniyal98 commented Oct 12, 2022

Description

closes: #1689


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

Codecov Report

Merging #2539 (acef7fd) into main (4bd05c6) will increase coverage by 0.04%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2539      +/-   ##
==========================================
+ Coverage   78.70%   78.74%   +0.04%     
==========================================
  Files         178      178              
  Lines       12311    12298      -13     
==========================================
- Hits         9689     9684       -5     
+ Misses       2195     2190       -5     
+ Partials      427      424       -3     
Impacted Files Coverage Δ
modules/apps/29-fee/types/msgs.go 90.43% <ø> (-0.33%) ⬇️
modules/core/02-client/types/msgs.go 75.73% <ø> (ø)
.../27-interchain-accounts/controller/types/params.go 47.82% <33.33%> (ø)
...s/apps/27-interchain-accounts/host/types/params.go 42.10% <33.33%> (ø)
modules/apps/transfer/types/params.go 48.00% <40.00%> (ø)
modules/apps/transfer/ibc_module.go 64.96% <66.66%> (+0.03%) ⬆️
modules/apps/transfer/keeper/msg_server.go 100.00% <100.00%> (ø)
modules/apps/transfer/keeper/relay.go 90.63% <100.00%> (+2.56%) ⬆️
modules/apps/transfer/types/msgs.go 95.12% <100.00%> (-0.12%) ⬇️
modules/apps/transfer/types/packet.go 92.00% <100.00%> (+0.33%) ⬆️
... and 1 more

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit. Otherwise, LGTM. Thanks a lot, @Daniyal98!

CHANGELOG.md Outdated Show resolved Hide resolved
@crodriguezvega crodriguezvega merged commit 9eb3875 into cosmos:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove GetVersions from Connection interface
4 participants