Invalid IBC Metrics

[alexanderbez]

Summary of Bug

IBC metrics break Prometheus metrics exposed in Tendermint's RPC.

An error has occurred while serving metrics:

5 error(s) occurred:
* "client-type" is not a valid label name for metric "gaia_ibc_client_update"
* "destination-port" is not a valid label name for metric "gaia_tx_msg_ibc_recv_packet"
* "source-port" is not a valid label name for metric "gaia_tx_msg_ibc_acknowledge_packet"
* "source-port" is not a valid label name for metric "gaia_ibc_transfer_receive"
* "destination-port" is not a valid label name for metric "gaia_ibc_transfer_send"

Version

$ gaiad version --long

name: gaia
server_name: gaiad
version: v4.2.1
commit: dbd8a6fb522c571debf958837f9113c56d418f6b
build_tags: netgo,ledger
go: go version go1.15.2 linux/amd64

Steps to Reproduce

1. Run a cosmoshub-4 node.
2. Sync to about ~6656325 block height.
3. Enable and query Tendermint's metrics @ host:26660/metrics

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

I'm surprised no one has noticed this...or have they already reported this? Can we get this fixed before the next SDK + Gaia release @AdityaSripal @colin-axner ?