Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ProposalContents simulation function #3150

Closed
3 tasks
colin-axner opened this issue Feb 15, 2023 · 0 comments · Fixed by #3154
Closed
3 tasks

Remove ProposalContents simulation function #3150

colin-axner opened this issue Feb 15, 2023 · 0 comments · Fixed by #3154

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Feb 15, 2023 •
edited
Loading

Summary

Remove the ProposalContents simulation function.

Problem Definition

As per SDK UPGRADING documention. The ProposalContents has become an optional interface function that can be used to submit legacy governance proposals. ProposalMsgs can be used to do simulations of gov v1 proposal msgs.

Proposal

We only support the AppModuleSimulation function so chains can run simulations when our modules are integrated. We do not rely on SDK simulations to provide any additional confidence in the correctness of our code, thus we do not need to worry about fulfilling these functions (optional)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Feb 15, 2023
Merged
9 tasks
colin-axner added a commit that referenced this issue Feb 15, 2023
@colin-axner
chore: apply changes from #3150
06d11da
damiannolan added a commit that referenced this issue Feb 15, 2023
@damiannolan @crodriguezvega @colin-axner
docs: adding migration doc info for sdk v0.47 (#3107)
f034e6b 
* adding migration doc info for sdk v0.47

* code alignment

* title formatting

* chore: preemptively apply changes from #3149

* chore: apply changes from #3150

* chore: formatting

* chore: combine proposal contents removal into existing section

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Colin Axnér <[email protected]>
mergify bot pushed a commit that referenced this issue Feb 15, 2023
@damiannolan @mergify
docs: adding migration doc info for sdk v0.47 (#3107)
57d3051 
* adding migration doc info for sdk v0.47

* code alignment

* title formatting

* chore: preemptively apply changes from #3149

* chore: apply changes from #3150

* chore: formatting

* chore: combine proposal contents removal into existing section

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Colin Axnér <[email protected]>
(cherry picked from commit f034e6b)

# Conflicts:
#	docs/migrations/v6-to-v7.md
stackman27 pushed a commit to stackman27/ibc-go that referenced this issue Mar 13, 2023
@damiannolan @crodriguezvega
@colin-axner @stackman27
docs: adding migration doc info for sdk v0.47 (cosmos#3107)
f956248 
* adding migration doc info for sdk v0.47

* code alignment

* title formatting

* chore: preemptively apply changes from cosmos#3149

* chore: apply changes from cosmos#3150

* chore: formatting

* chore: combine proposal contents removal into existing section

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Colin Axnér <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove unused ProposalContents function cosmos/ibc-go
1 participant
@colin-axner