Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packet flushing logic to acknowledgement flow #3878

Closed
1 task
crodriguezvega opened this issue Jun 17, 2023 · 0 comments
Closed
1 task

Add packet flushing logic to acknowledgement flow #3878

crodriguezvega opened this issue Jun 17, 2023 · 0 comments
Assignees

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jun 17, 2023

Pre-requisite:

After deleting the packet commitment, change flush status to FLUSHCOMPLETE if the flush status is FLUSHING and there are no pending in-flight packets.

Question: to follow a similar pattern as we do for ChanOpen[Try, Ack, Confirm] message server handler functions where we have functions WriteOpen[Try, Ack, Confirm]Channel writing the channel state, should we have also a WriteAcknowledgePacketChannel (or with different name) function that writes the change of channel state? Since the logic is the same also for TimeoutPacket and TimeoutOnClose maybe we can have one implementation that can be used for all three.

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jun 17, 2023
@DimitrisJim DimitrisJim self-assigned this Jun 22, 2023
@DimitrisJim DimitrisJim moved this from Todo to In progress in ibc-go Jun 22, 2023
@DimitrisJim DimitrisJim moved this from In progress to In review in ibc-go Jun 29, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants