Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ics04: Channel Upgrade Packet Flushing Logic #982

Merged
merged 7 commits into from
Jul 6, 2023

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented Jun 12, 2023

Implement the ICS26 module changes necessary to modulate the flushStatus field during regular packet and channel handshake handlers

closes: #975
closes: #973

@AdityaSripal AdityaSripal marked this pull request as ready for review June 12, 2023 12:46
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but see concerns around channels closing during an upgrade (would like to fix ordered channel closing logic before merge)

spec/core/ics-004-channel-and-packet-semantics/README.md Outdated Show resolved Hide resolved
spec/core/ics-004-channel-and-packet-semantics/README.md Outdated Show resolved Hide resolved
spec/core/ics-004-channel-and-packet-semantics/README.md Outdated Show resolved Hide resolved
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me. I just found one typo I think!

spec/core/ics-004-channel-and-packet-semantics/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AdityaSripal!

@crodriguezvega crodriguezvega merged commit 63fce39 into main Jul 6, 2023
@crodriguezvega crodriguezvega deleted the aditya/packet-flush branch July 6, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Add UpgradeSequence and FlushStatus to Channel type Handle Packet processing during upgrade handshakes
4 participants