Reduce complexity of SerializeCosmosTx/DeserializeCosmosTx #452
Assignees
Labels
27-interchain-accounts
audit
Feedback from implementation audit
type: code hygiene
Clean up code but without changing functionality or interfaces
Milestone
Comments
seantking
added
type: code hygiene
9 tasks
faddat
pushed a commit
to notional-labs/ibc-go
that referenced
this issue
Feb 23, 2022
Upgrade cosmos-sdk to v0.42.0
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this issue
Nov 6, 2023
* Add gossip fraud proof capability over p2p (cosmos#452) * Add types.proto for new tendermint version with abci methods * Trigger Fraud Proof WIP * Add new abci method in mocks all across tests * Add fraudproof trigger * Remove fraud trigger integration test * Remove getAppHash from mock.on * Write a fraudproof integration test * Replace Generate with trigger * Add skeleton to catch up and generate fraudproof after FPGM * Remove triggerFraudProofGenerationMode and refactor * Add generate fraud proof * Wrap all fraudproof logic within a flag * Update types.proto * Add fraud proof verification WIP * Update state/executor.go Co-authored-by: Tomasz Zdybał <[email protected]> * Refactor genAndGossipFraudProofIfNeeded * Revert fraudproof type to remove serialization errors * Remove local dependencies from go mod file * Update go.mod file to have specific commit sha hash of celestiaorg/tendermint with new ABCI methods * deps: update protobuf scripts & files to use correct version Currently we need to use Manav's branch from celestiaorg/tendermint fork. * Update node/integration_test.go Co-authored-by: Tomasz Zdybał <[email protected]> * Call get_deps.sh and update abci types.proto * Update spelling of comparison bc linter errors * Change rollmint ethermint to optimint * Delete version/types.proto file * Add inline comment explaining integration test check * Do not downgrade tendermint version * Update proto/get_deps.sh Co-authored-by: Tomasz Zdybał <[email protected]> * deps: celestiaorg/tendermint@abci_fraud_proofs * Refactor code into createAndStartNodes Co-authored-by: Tomasz Zdybał <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
At present, the serialization/deserialization of transactions is overly complex. We can reduce complexity by forcing the
TrySendTxAPI to only take an array of SDK messages rather than accepting a single SDK message.DeserializeTx should be renamed to
DeserializeCosmosTxThis task is dependent on #449
For Admin Use
The text was updated successfully, but these errors were encountered: