Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment when setting the version to counterparty version #5221

Closed
Tracked by #5201
chatton opened this issue Nov 29, 2023 · 0 comments
Closed
Tracked by #5201

Add comment when setting the version to counterparty version #5221

chatton opened this issue Nov 29, 2023 · 0 comments
Assignees
Labels
channel-upgradability Channel upgradability feature

Comments

@chatton
Copy link
Contributor

chatton commented Nov 29, 2023

Add comment when setting the version to counterparty version that the optimstism refers to failing in OnChanOpenAck callback.

@chatton chatton changed the title Add comment [when setting the version to counterparty version](https://github.com/cosmos/ibc-go/blob/39df8d2b579fc623a1e748b4330738ff40adb682/modules/core/04-channel/keeper/upgrade.go#L282) that the optimstism refers to failing in OnChanOpenAck callback. Add comment when setting the version to counterparty version Nov 29, 2023
@chatton chatton added the channel-upgradability Channel upgradability feature label Nov 29, 2023
@chatton chatton self-assigned this Nov 29, 2023
@DimitrisJim DimitrisJim moved this to In review in ibc-go Nov 30, 2023
@chatton chatton closed this as completed Nov 30, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

1 participant