Items from channel upgradability alpha walkthrough

[crodriguezvega]

Each task can be completed in a different PR. Please open an issue for the task you plan to pick up and assign it to yourself.

Tasks

Beta Give feedback

1. Godoc of validateSelfUpgradeFields needs to be updated (order doesn’t need to be a subset) #5202
   +0
   
2. Change the error returned (ErrChannelExists) in validateSelfUpgradeFields when the proposed upgrade fields match the channel current parameters #5204
   +0
   
3. Add comment in ChanUpgradeInit that a nil timeout is intentionally returned #5206
   +0
   
4. Return in MsgChannelUpgradeInitResponse only the upgrade version and the upgrade sequence. #5219
   channel-upgradability +1
   
5. Panic in WriteErrorReceipt instead of returning an error #5207
   +0
   
6. Pass the upgrade version returned by OnChanUpgradeInit to WriteUpgradeInitChannel instead of updating upgrade.Fields.Version in the message server. #5208
   +0
   
7. In ChanUpgradeTry move fast forward sequence down below after the call to ChanUpgradeInit. #5218
   +0
   
8. Move events to message server layer instead of core level. #5217
   04-channel channel-upgradability +2
   
9. Remove latestPacketSend from NewUpgrade constructor #5209
   +0
   
10. Add comment above or in the godoc (channel state is open, if chain executed init; or flushing, if it executed try). #5220
    channel-upgradability +1
    
11. Add comment when setting the version to counterparty version #5221
    channel-upgradability +1
    
12. WriteUpgradeAckChannel should have errors instead of just string (replace fmt.Sprintf with fmt.Errorf). #5222
    channel-upgradability +1
    
13. Add comment to explain what the counterparty upgrade is used for. #5223
    channel-upgradability +1
    
14. In ChanUpgradeTry it might be nice to add a note that we explicitly only set error receipts, the upgrade will not be aborted until it is proved to be incompatible in ChanUpgradeAck`. #5224
    channel-upgradability +1
15. Change so that if the counterparty upgrade is found then we execute the code below #5225
    channel-upgradability +1
    
16. Remove setting counterparty upgrade info in upgrade try #5227
    channel-upgradability +1
    
17. Remove incorrect code in TimeoutPacket #5211
    04-channel channel-upgradability +2
    
18. Proof in MsgChannelUpgradeCancel is allowed to be empty (gov override) #5229
    +0
    
19. Allow error receipt to be nil in ValidateBasic for MsgChannelUpgradeCancel #5260
    +0
    
20. Make sure that the error receipt we write always has a sequence greater than the existing one. #5226
    channel-upgradability +1
    
21. Call WriteUpgradeOpenChannel before calling application callback #5213
    04-channel channel-upgradability +2
    

[hieuvubk]

Could I pick up some task?

[chatton]

@hieuvubk sure! Which one would you like to grab?

[hieuvubk]

@hieuvubk sure! Which one would you like to grab?

5th & 6th I think, I cant edit the description for new issues :(((

[crodriguezvega]

@hieuvubk sure! Which one would you like to grab?

5th & 6th I think, I cant edit the description for new issues :(((

Thank you, @hieuvubk. I opened issues for those. Can you comment on them? Then I will be able to assign them to you.

[ThanhNhann]

Hi @crodriguezvega, can you list all the issues above so I and another guys of my team can pick it? ❤️

[DimitrisJim]

guess it might be best to open them all and have people comment on each specific issue?

[colin-axner]

Looks like we can close this issue now?

[DimitrisJim]

@colin-axner we most definitely can from the looks of it. Thank you all for contributing to this issue!