Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change so that if the counterparty upgrade is found then we execute the code below #5225

Closed
Tracked by #5201
chatton opened this issue Nov 29, 2023 · 4 comments
Closed
Tracked by #5201

Change so that if the counterparty upgrade is found then we execute the code below #5225

chatton opened this issue Nov 29, 2023 · 4 comments
Assignees
@GNaD13
Labels
channel-upgradability Channel upgradability feature

Comments

@chatton
Copy link
Contributor

chatton commented Nov 29, 2023 •
edited
Loading

Change this condition so that if the counterparty upgrade is found then we execute the code below, otherwise we just continue instead of returning an error.
@chatton chatton mentioned this issue Nov 29, 2023
Closed
@chatton chatton changed the title Change [this condition](https://github.com/cosmos/ibc-go/blob/39df8d2b579fc623a1e748b4330738ff40adb682/modules/core/04-channel/keeper/timeout.go#L156) so that if the counterparty upgrade is found then we execute the code below, otherwise we just continue instead of returning an error. Change so that if the counterparty upgrade is found then we execute the code below Nov 29, 2023
@chatton chatton added the channel-upgradability Channel upgradability feature label Nov 29, 2023
@GNaD13
Copy link
Contributor

GNaD13 commented Nov 29, 2023

Hi sir @chatton, can I take this issue?

@chatton
Copy link
Contributor Author

chatton commented Nov 29, 2023

Thanks @GNaD13 !

@GNaD13
Copy link
Contributor

GNaD13 commented Dec 5, 2023

Hi sir @chatton, sorry for late of the work. I think this issue can close by #5238

@crodriguezvega
Copy link
Contributor

@GNaD13 you're right!

Closed by #5238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GNaD13 GNaD13

Labels
channel-upgradability Channel upgradability feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crodriguezvega @chatton @GNaD13