Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ics29: capitalise ID in local packetId var names #742

Closed
3 tasks
damiannolan opened this issue Jan 17, 2022 · 0 comments
Closed
3 tasks

ics29: capitalise ID in local packetId var names #742

damiannolan opened this issue Jan 17, 2022 · 0 comments
Labels
29-fee good first issue Good for newcomers
Milestone
Fee middleware beta

Comments

@damiannolan
Copy link
Member

Summary

Variables names in ics29 should be updated to use ID in variable names to align with ibc-go codebase.

packetId -> packetID

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added good first issue Good for newcomers 29-fee labels Jan 17, 2022
@damiannolan damiannolan mentioned this issue Jan 17, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega added this to the Fee middleware beta milestone Mar 29, 2022
@seantking seantking mentioned this issue Apr 4, 2022
Merged
9 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tuxcanfly
ws: support cors (cosmos#864)
01e83ce 
The websocket JSON RPC server did not support CORS. This PR implements
this. Fixes cosmos#436 cosmos#742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
29-fee good first issue Good for newcomers
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @seantking