Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination chain must reference packetID with Destination channel/port #757

Closed
AdityaSripal opened this issue Jan 18, 2022 · 3 comments
Closed

Destination chain must reference packetID with Destination channel/port #757

AdityaSripal opened this issue Jan 18, 2022 · 3 comments
Assignees
@seantking
Labels
29-fee

Comments

@AdityaSripal
Copy link
Member

Must use dest channel/port on receiving chain rather than source channel/port.

https://github.com/cosmos/ibc-go/blob/ics29-fee-middleware/modules/apps/29-fee/ibc_module.go#L191

https://github.com/cosmos/ibc-go/blob/ics29-fee-middleware/modules/apps/29-fee/keeper/relay.go#L21
@colin-axner colin-axner self-assigned this Feb 9, 2022
@colin-axner
Copy link
Contributor

requires #891

@colin-axner colin-axner removed their assignment Feb 9, 2022
@colin-axner
Copy link
Contributor

can be done after merging #927

@colin-axner
Copy link
Contributor

The WriteAcknowledgement test/fix can be done without #927

@seantking seantking self-assigned this Feb 21, 2022
@seantking seantking mentioned this issue Feb 21, 2022
Merged
9 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@dependabot
build(deps): bump golang.org/x/net from 0.7.0 to 0.8.0 (cosmos#757)
602b915 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to
0.8.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/golang/net/commit/dfa2b5dffd96fb2ae13e7d182501f0bce044a0a4"><code>dfa2b5d</code></a>
go.mod: update golang.org/x dependencies</li>
<li><a
href="https://github.com/golang/net/commit/8c4ef2f86b571fd6b859ef409ccf05284e852214"><code>8c4ef2f</code></a>
hmtl: add security section to package comment</li>
<li><a
href="https://github.com/golang/net/commit/1d46ed8b487a394ccf6d67de0a95b76ebc0b8aba"><code>1d46ed8</code></a>
html: have Render escape comments less often</li>
<li><a
href="https://github.com/golang/net/commit/569fe8158ca38ebec97f9307039772123dc6a98f"><code>569fe81</code></a>
html: add &quot;Microsoft Outlook comment&quot; tests</li>
<li>See full diff in <a
href="https://github.com/golang/net/compare/v0.7.0...v0.8.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.7.0&new-version=0.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seantking seantking

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seantking @AdityaSripal @colin-axner