Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change fee version string to make it consistent with transfer version #1305

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

crodriguezvega
Copy link
Contributor

Description

I propose to change the version string so that it follows the same pattern that we use in transfer.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crodriguezvega crodriguezvega changed the title change version to make it consistent with transfer version change version string to make it consistent with transfer version Apr 27, 2022
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was in my brain backlog for a while and got lost 😆

@crodriguezvega crodriguezvega changed the title change version string to make it consistent with transfer version change fee version string to make it consistent with transfer version Apr 27, 2022
@crodriguezvega crodriguezvega merged commit 9aea0fe into main Apr 27, 2022
@crodriguezvega crodriguezvega deleted the carlos/change-fee-version-string branch April 27, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants