Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 005: update client consensus height events #1315

Merged

Conversation

damiannolan
Copy link
Member

Description

  • Adding ADR 005 - UpdateClient Events - ClientState Consensus Heights

closes: #1280


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@damiannolan
Copy link
Member Author

All suggestions welcome, originally I had written more but decided to trim it back to keep this concise.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your first ADR, yuhhuu! 🥳

docs/architecture/adr-005-consensus-height-events.md Outdated Show resolved Hide resolved
docs/architecture/adr-005-consensus-height-events.md Outdated Show resolved Hide resolved
docs/architecture/adr-005-consensus-height-events.md Outdated Show resolved Hide resolved
docs/architecture/adr-005-consensus-height-events.md Outdated Show resolved Hide resolved
docs/architecture/adr-005-consensus-height-events.md Outdated Show resolved Hide resolved
docs/architecture/adr-005-consensus-height-events.md Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding! Well written 💯

@crodriguezvega crodriguezvega merged commit d120044 into 02-client-refactor May 10, 2022
@crodriguezvega crodriguezvega deleted the damian/1280-adr-consensus-height-events branch May 10, 2022 12:03
oshorefueled pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
* adding context section and draft notes for decision section

* updating adr with decisions and consequences sections

* adding references to adr 005

* removing decision templating

* Apply suggestions from code review

Co-authored-by: Carlos Rodriguez <[email protected]>

* adding versioned links

* reorder decision points, add additional info on header cross-checking

* typo

Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants