Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding on-chain params to ics29 fee middleware #1482

Closed
wants to merge 6 commits into from

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Jun 1, 2022

Description

  • Adding on-chain parameters to apps/29-fee including DistributionAddress field

ref: #1477


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@damiannolan
Copy link
Member Author

This will require a follow-up PR for implementing the logic set out in #1477, allowing overwriting of the ics29 fee payee address

@damiannolan
Copy link
Member Author

Based on the discussion in #1477 I'll close this PR considering the choice of direction.
This PR could be resurrected in future for on-chain params for 29-fee as it covers the basic implementation

@damiannolan damiannolan closed this Jun 3, 2022
@damiannolan damiannolan deleted the damian/1477-ics29-distribution-addr-param branch August 3, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant