refactor: solomachine generic verification methods and signbytes simplification #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
commented
Jul 12, 2022
modules/light-clients/06-solomachine/types/client_state_test.go
Outdated
Show resolved
Hide resolved
colin-axner
reviewed
Jul 13, 2022
This was referenced Jul 15, 2022
* adding SignatureAndDataV2 proto message type * updating misbehaviour checking * removing dead solomachine code (#1716)
* adding verification of non-membership with tests * refactor common code to produceVerificationArgs * removing unused produce args func * Update modules/light-clients/06-solomachine/client_state_test.go Co-authored-by: colin axnér <[email protected]> Co-authored-by: colin axnér <[email protected]>
damiannolan
changed the title
damiannolan
requested review from
fedekunze,
AdityaSripal,
crodriguezvega,
seantking and
charleenfei
as code owners
colin-axner
reviewed
Aug 1, 2022
There was a problem hiding this comment.
I love these changes so much ❤️ Cleans up a lot of unnecessary code. Thanks for handling these changes and splitting them up in a very digestible way. The code is very clean!
Everything LGTM, the only change I'd block merge on is I believe we need to bump the proto version for the structs which have changed
colin-axner
reviewed
Aug 1, 2022
* add test for successful new diversifier * add changelog entry * fix tests
… solomachine/v3 protobuf defs
charleenfei
reviewed
Aug 2, 2022
| ConsensusState consensus_state = 3 [(gogoproto.moretags) = "yaml:\"consensus_state\""]; | ||
| // when set to true, will allow governance to update a solo machine client. | ||
| // The client will be unfrozen if it is frozen. | ||
| bool allow_update_after_proposal = 4 [(gogoproto.moretags) = "yaml:\"allow_update_after_proposal\""]; |
There was a problem hiding this comment.
are we actually checking this bool anywhere?
There was a problem hiding this comment.
@colin-axner and I actually spoke about potentially removing this yesterday. It could be done in a follow up
There was a problem hiding this comment.
we are. I think we should just remove it for the same reasoning we did in 07-tendermint (gov always can do a migration if they really want to). Agreed?
I can do it in a followup if we agree
This was referenced Aug 4, 2022
oshorefueled
pushed a commit
to ComposableFi/ibc-go
that referenced
this pull request
Aug 9, 2022
…lification (cosmos#1687) * adding new SignBytes type, generic membership verification implementation and tests * adding protodocs * updating comment * refactor: solomachine misbehaviour checking (cosmos#1715) * adding SignatureAndDataV2 proto message type * updating misbehaviour checking * removing dead solomachine code (cosmos#1716) * updating tests with concrete ibc core types * refactor: solomachine generic VerifyNonMembership (cosmos#1720) * adding verification of non-membership with tests * refactor common code to produceVerificationArgs * removing unused produce args func * Update modules/light-clients/06-solomachine/client_state_test.go Co-authored-by: colin axnér <[email protected]> Co-authored-by: colin axnér <[email protected]> * removing V2 suffix from SignBytes and SignatureAndData types * use current diversifier when verifying header details * Add test for new diversifier for solomachine (cosmos#1860) * add test for successful new diversifier * add changelog entry * fix tests * restoring solomachine/v2 protos, updadting v2 codegen path and adding solomachine/v3 protobuf defs * adding changelog entries Co-authored-by: colin axnér <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SignBytesmessage type ( noteV2suffix will be dropped when PRs are upstreamed to this branch)VerifyMembershipimplementationneeds:
closes: #1292 #1295 #1141
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes