-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate go mod for e2e (E2E #4) #1701
Changes from all commits
47be6be
ce80411
bfbba03
4569fa5
272ad61
6afe90c
7497574
7091fbc
6ebcc6d
05d9a45
308eb0f
9ebacd7
c431850
3c4f62b
b5fff2a
abb0eca
f36025b
9039137
30591c9
b43d07e
b1bcc12
d740296
e94d35b
848f888
99328b1
35e454f
ccd9fd5
e154f09
236eb9f
11227eb
7541beb
e768a46
ce2828e
2f77cd3
0cfac25
5753fa4
9ebbed4
58a0fd5
9b2ffba
1c2e239
da2c8b9
48d7741
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
DOCKER := $(shell which docker) | ||
TEST_CONTAINERS=$(shell docker ps --filter "label=ibc-test" -a -q) | ||
|
||
cleanup-ibc-test-containers: | ||
for id in $(TEST_CONTAINERS) ; do \ | ||
$(DOCKER) stop $$id ; \ | ||
$(DOCKER) rm $$id ; \ | ||
done | ||
|
||
e2e-test: cleanup-ibc-test-containers | ||
@go test -v ./ --run $(suite) -testify.m ^$(test)$$ | ||
|
||
.PHONY: cleanup-ibc-test-containers e2e-test |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,142 @@ | ||
module e2e | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this common practice? I would think the import should be "github.com/cosmos/ibc-go/e2e"? What would the differences be between using the different module paths? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was initially thinking of to do something like this, but opted to remove the |
||
|
||
go 1.18 | ||
|
||
replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | ||
|
||
require ( | ||
github.com/docker/docker v20.10.17+incompatible | ||
github.com/strangelove-ventures/ibctest v0.0.0-20220713213153-930886d8db30 | ||
github.com/stretchr/testify v1.8.0 | ||
go.uber.org/zap v1.21.0 | ||
) | ||
|
||
require ( | ||
filippo.io/edwards25519 v1.0.0-beta.2 // indirect | ||
github.com/99designs/keyring v1.1.6 // indirect | ||
github.com/ChainSafe/go-schnorrkel v0.0.0-20200405005733-88cbf1b4c40d // indirect | ||
github.com/DataDog/zstd v1.4.5 // indirect | ||
github.com/Microsoft/go-winio v0.5.1 // indirect | ||
github.com/armon/go-metrics v0.4.0 // indirect | ||
github.com/avast/retry-go/v4 v4.0.4 // indirect | ||
github.com/benbjohnson/clock v1.1.0 // indirect | ||
github.com/beorn7/perks v1.0.1 // indirect | ||
github.com/bgentry/speakeasy v0.1.0 // indirect | ||
github.com/btcsuite/btcd v0.22.0-beta // indirect | ||
github.com/cespare/xxhash v1.1.0 // indirect | ||
github.com/cespare/xxhash/v2 v2.1.2 // indirect | ||
github.com/confio/ics23/go v0.7.0 // indirect | ||
github.com/cosmos/btcutil v1.0.4 // indirect | ||
github.com/cosmos/cosmos-sdk v0.45.6 // indirect | ||
github.com/cosmos/go-bip39 v1.0.0 // indirect | ||
github.com/cosmos/iavl v0.17.3 // indirect | ||
github.com/cosmos/ibc-go/v4 v4.0.0-rc0 // indirect | ||
github.com/cosmos/ledger-cosmos-go v0.11.1 // indirect | ||
github.com/cosmos/ledger-go v0.9.2 // indirect | ||
github.com/danieljoos/wincred v1.0.2 // indirect | ||
github.com/davecgh/go-spew v1.1.1 // indirect | ||
github.com/dgraph-io/badger/v2 v2.2007.2 // indirect | ||
github.com/dgraph-io/ristretto v0.0.3 // indirect | ||
github.com/dgryski/go-farm v0.0.0-20200201041132-a6ae2369ad13 // indirect | ||
github.com/docker/distribution v2.8.1+incompatible // indirect | ||
github.com/docker/go-connections v0.4.0 // indirect | ||
github.com/docker/go-units v0.4.0 // indirect | ||
github.com/dustin/go-humanize v1.0.0 // indirect | ||
github.com/dvsekhvalnov/jose2go v0.0.0-20200901110807-248326c1351b // indirect | ||
github.com/felixge/httpsnoop v1.0.1 // indirect | ||
github.com/fsnotify/fsnotify v1.5.4 // indirect | ||
github.com/go-kit/kit v0.12.0 // indirect | ||
github.com/go-kit/log v0.2.0 // indirect | ||
github.com/go-logfmt/logfmt v0.5.1 // indirect | ||
github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect | ||
github.com/gogo/gateway v1.1.0 // indirect | ||
github.com/gogo/protobuf v1.3.3 // indirect | ||
github.com/golang/protobuf v1.5.2 // indirect | ||
github.com/golang/snappy v0.0.3 // indirect | ||
github.com/google/btree v1.0.0 // indirect | ||
github.com/google/uuid v1.3.0 // indirect | ||
github.com/gorilla/handlers v1.5.1 // indirect | ||
github.com/gorilla/mux v1.8.0 // indirect | ||
github.com/gorilla/websocket v1.5.0 // indirect | ||
github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect | ||
github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect | ||
github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect | ||
github.com/gtank/merlin v0.1.1 // indirect | ||
github.com/gtank/ristretto255 v0.1.2 // indirect | ||
github.com/hashicorp/go-immutable-radix v1.3.1 // indirect | ||
github.com/hashicorp/golang-lru v0.5.4 // indirect | ||
github.com/hashicorp/hcl v1.0.0 // indirect | ||
github.com/hdevalence/ed25519consensus v0.0.0-20210204194344-59a8610d2b87 // indirect | ||
github.com/inconshreveable/mousetrap v1.0.0 // indirect | ||
github.com/jmhodges/levigo v1.0.0 // indirect | ||
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect | ||
github.com/keybase/go-keychain v0.0.0-20190712205309-48d3d31d256d // indirect | ||
github.com/libp2p/go-buffer-pool v0.0.2 // indirect | ||
github.com/magiconair/properties v1.8.6 // indirect | ||
github.com/mattn/go-isatty v0.0.14 // indirect | ||
github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369 // indirect | ||
github.com/mimoo/StrobeGo v0.0.0-20181016162300-f8f6d4d2b643 // indirect | ||
github.com/mitchellh/go-homedir v1.1.0 // indirect | ||
github.com/mitchellh/mapstructure v1.5.0 // indirect | ||
github.com/mtibben/percent v0.2.1 // indirect | ||
github.com/opencontainers/go-digest v1.0.0 // indirect | ||
github.com/opencontainers/image-spec v1.0.3-0.20211202183452-c5a74bcca799 // indirect | ||
github.com/pelletier/go-toml v1.9.5 // indirect | ||
github.com/pelletier/go-toml/v2 v2.0.1 // indirect | ||
github.com/petermattis/goid v0.0.0-20180202154549-b0b1615b78e5 // indirect | ||
github.com/pkg/errors v0.9.1 // indirect | ||
github.com/pmezard/go-difflib v1.0.0 // indirect | ||
github.com/prometheus/client_golang v1.12.1 // indirect | ||
github.com/prometheus/client_model v0.2.0 // indirect | ||
github.com/prometheus/common v0.32.1 // indirect | ||
github.com/prometheus/procfs v0.7.3 // indirect | ||
github.com/rakyll/statik v0.1.7 // indirect | ||
github.com/rcrowley/go-metrics v0.0.0-20200313005456-10cdbea86bc0 // indirect | ||
github.com/regen-network/cosmos-proto v0.3.1 // indirect | ||
github.com/remyoudompheng/bigfft v0.0.0-20200410134404-eec4a21b6bb0 // indirect | ||
github.com/sasha-s/go-deadlock v0.2.1-0.20190427202633-1595213edefa // indirect | ||
github.com/sirupsen/logrus v1.8.1 // indirect | ||
github.com/spf13/afero v1.8.2 // indirect | ||
github.com/spf13/cast v1.5.0 // indirect | ||
github.com/spf13/cobra v1.5.0 // indirect | ||
github.com/spf13/jwalterweatherman v1.1.0 // indirect | ||
github.com/spf13/pflag v1.0.5 // indirect | ||
github.com/spf13/viper v1.12.0 // indirect | ||
github.com/subosito/gotenv v1.3.0 // indirect | ||
github.com/syndtr/goleveldb v1.0.1-0.20200815110645-5c35d600f0ca // indirect | ||
github.com/tecbot/gorocksdb v0.0.0-20191217155057-f0fad39f321c // indirect | ||
github.com/tendermint/btcd v0.1.1 // indirect | ||
github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15 // indirect | ||
github.com/tendermint/go-amino v0.16.0 // indirect | ||
github.com/tendermint/tendermint v0.34.19 // indirect | ||
github.com/tendermint/tm-db v0.6.6 // indirect | ||
github.com/zondax/hid v0.9.0 // indirect | ||
go.etcd.io/bbolt v1.3.6 // indirect | ||
go.uber.org/atomic v1.9.0 // indirect | ||
go.uber.org/multierr v1.7.0 // indirect | ||
golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 // indirect | ||
golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 // indirect | ||
golang.org/x/net v0.0.0-20220520000938-2e3eb7b945c2 // indirect | ||
golang.org/x/sync v0.0.0-20220513210516-0976fa681c29 // indirect | ||
golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a // indirect | ||
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect | ||
golang.org/x/text v0.3.7 // indirect | ||
golang.org/x/tools v0.1.10 // indirect | ||
golang.org/x/xerrors v0.0.0-20220517211312-f3a8303e98df // indirect | ||
google.golang.org/genproto v0.0.0-20220519153652-3a47de7e79bd // indirect | ||
google.golang.org/grpc v1.47.0 // indirect | ||
google.golang.org/protobuf v1.28.0 // indirect | ||
gopkg.in/ini.v1 v1.66.4 // indirect | ||
gopkg.in/yaml.v2 v2.4.0 // indirect | ||
gopkg.in/yaml.v3 v3.0.1 // indirect | ||
lukechampine.com/uint128 v1.1.1 // indirect | ||
modernc.org/cc/v3 v3.36.0 // indirect | ||
modernc.org/ccgo/v3 v3.16.6 // indirect | ||
modernc.org/libc v1.16.7 // indirect | ||
modernc.org/mathutil v1.4.1 // indirect | ||
modernc.org/memory v1.1.1 // indirect | ||
modernc.org/opt v0.1.1 // indirect | ||
modernc.org/sqlite v1.17.3 // indirect | ||
modernc.org/strutil v1.1.1 // indirect | ||
modernc.org/token v1.0.0 // indirect | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly a Makefile guru, but should these be
.PHONY
targets as they're not creating an output file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are absolutely correct, thanks for spotting that!