fix: assert previous connection id to be empty #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evious connection id to be empty
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
seantking,
charleenfei,
damiannolan and
chatton
as code owners
colin-axner
commented
Jul 27, 2022
Comment on lines
-131
to
-132
| {"invalid connection ID", types.NewMsgConnectionOpenTry("test/conn1", "clienttotesta", "connectiontotest", "clienttotest", clientState, prefix, []*types.Version{ibctesting.ConnectionVersion}, 500, suite.proof, suite.proof, suite.proof, clientHeight, clientHeight, signer), false}, | ||
| {"invalid connection ID", types.NewMsgConnectionOpenTry("(invalidconnection)", "clienttotesta", "connectiontotest", "clienttotest", clientState, prefix, []*types.Version{ibctesting.ConnectionVersion}, 500, suite.proof, suite.proof, suite.proof, clientHeight, clientHeight, signer), false}, |
There was a problem hiding this comment.
I removed one of these and replaced the other with the non empty connection ID test
…osmos/ibc-go into colin/1777-remove-connection-leftovers
crodriguezvega
approved these changes
Jul 28, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
* remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md
crodriguezvega
added a commit
that referenced
this pull request
Jul 29, 2022
* fix: assert previous connection id to be empty (#1797) * remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 27, 2023
…cosmos#1828) * fix: assert previous connection id to be empty (cosmos#1797) * remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
…cosmos#1828) * fix: assert previous connection id to be empty (cosmos#1797) * remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
…cosmos#1828) * fix: assert previous connection id to be empty (cosmos#1797) * remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1777
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes