Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add params for ics27 simulation #2160

Merged
merged 13 commits into from
Sep 7, 2022
Merged

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Aug 31, 2022

Description

closes: #1352
closes: #2151


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner marked this pull request as ready for review September 6, 2022 11:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #2160 (7985051) into main (96b0aae) will increase coverage by 0.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2160      +/-   ##
==========================================
+ Coverage   79.48%   79.49%   +0.01%     
==========================================
  Files         173      174       +1     
  Lines       12011    12028      +17     
==========================================
+ Hits         9547     9562      +15     
- Misses       2042     2044       +2     
  Partials      422      422              
Impacted Files Coverage Δ
modules/apps/27-interchain-accounts/module.go 50.53% <0.00%> (-1.12%) ⬇️
...s/apps/27-interchain-accounts/simulation/params.go 100.00% <100.00%> (ø)

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! LGTM 🚀

@colin-axner colin-axner merged commit cd913b8 into main Sep 7, 2022
@colin-axner colin-axner deleted the colin/1352-simparams branch September 7, 2022 11:15
mergify bot pushed a commit that referenced this pull request Sep 7, 2022
* add param changes for ics27 simulation

* account for unadded submodules

* fix tests

* Update modules/apps/27-interchain-accounts/module.go

* add app simulation declaration

(cherry picked from commit cd913b8)

# Conflicts:
#	modules/apps/27-interchain-accounts/module.go
mergify bot pushed a commit that referenced this pull request Sep 7, 2022
* add param changes for ics27 simulation

* account for unadded submodules

* fix tests

* Update modules/apps/27-interchain-accounts/module.go

* add app simulation declaration

(cherry picked from commit cd913b8)

# Conflicts:
#	modules/apps/27-interchain-accounts/module.go
colin-axner added a commit that referenced this pull request Sep 8, 2022
* add param changes for ics27 simulation

* account for unadded submodules

* fix tests

* Update modules/apps/27-interchain-accounts/module.go

* add app simulation declaration

(cherry picked from commit cd913b8)

# Conflicts:
#	modules/apps/27-interchain-accounts/module.go

Co-authored-by: colin axnér <[email protected]>
colin-axner added a commit that referenced this pull request Sep 8, 2022
* feat: add params for ics27 simulation (#2160)

* add param changes for ics27 simulation

* account for unadded submodules

* fix tests

* Update modules/apps/27-interchain-accounts/module.go

* add app simulation declaration

(cherry picked from commit cd913b8)

# Conflicts:
#	modules/apps/27-interchain-accounts/module.go

* fix conflicts

Co-authored-by: colin axnér <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty ICA state causes a panic on ExportGenesis Add simulations for 27-interchain-accounts app
4 participants