Fix missing events in OnRecvPacket #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluele
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
colin-axner
approved these changes
Jul 6, 2021
colin-axner
requested changes
Jul 6, 2021
|
Great catch! Agreed with Colin that we should emit events regardless of callback success. We must document to developers that state gets reverted but any emitted events still get emitted even in error case |
bluele
force-pushed
the
fix-recvpacket-events
branch
from
e2c5746
to
c607317
Compare
|
@colin-axner |
AdityaSripal
reviewed
Jul 6, 2021
AdityaSripal
approved these changes
Jul 6, 2021
colin-axner
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
LGTM, thanks for the contribution @bluele and the fast response time!
bluele
added a commit
to datachainlab/ibc-go
that referenced
this pull request
Jul 6, 2021
* fix to set events to the original context * Update modules/core/keeper/msg_server.go Co-authored-by: Aditya <[email protected]> Co-authored-by: colin axnér <[email protected]>
colin-axner
added a commit
that referenced
this pull request
Jul 6, 2021
* fix to set events to the original context * Update modules/core/keeper/msg_server.go Co-authored-by: Aditya <[email protected]> Co-authored-by: colin axnér <[email protected]>
colin-axner
added a commit
that referenced
this pull request
Jul 7, 2021
* Fix/channel open/close events (#220) * fix: moving event to keeper function instead of rpc handler * refactor: removing unnecessary handler * refactor: delete channel handler file * Apply suggestions from code review Co-authored-by: Aditya <[email protected]> * ibc: fix metrics (#223) * add missing changelog entries (#230) * add missing changelog entries * add missing entry * Fix missing events in OnRecvPacket (#233) * fix to set events to the original context * Update modules/core/keeper/msg_server.go Co-authored-by: Aditya <[email protected]> Co-authored-by: colin axnér <[email protected]> * bump SDK dependency to v0.43.0-rc0 (#229) Co-authored-by: Aditya <[email protected]> * Sentinel Root Fix (#234) * fix sentinel value * add godoc and test * fix grammar * add changelog Co-authored-by: colin axnér <[email protected]> * export connection params (#242) * ensure latest height revision number matches chain id revision number (#241) * ensure latest height revision number matches chain id revision number fix tests as well * add changelog * Update modules/light-clients/07-tendermint/types/client_state_test.go * Update modules/light-clients/07-tendermint/types/client_state_test.go * address review suggestions * fix merge conflict Co-authored-by: Sean King <[email protected]> Co-authored-by: Aditya <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Jun Kimura <[email protected]>
bluele
added a commit
to datachainlab/ibc-go
that referenced
this pull request
Sep 3, 2021
* fix to set events to the original context * Update modules/core/keeper/msg_server.go Co-authored-by: Aditya <[email protected]> Co-authored-by: colin axnér <[email protected]>
faddat
referenced
this pull request
in notional-labs/ibc-go
Feb 23, 2022
Restrict querier redispatched gas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The events set in the cache context need to be set in the original context.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes