improvement: added module names in channel callback errors

[alizahidraja]

Description

Included Module names in channel callback errors

closes: #1728

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests (does not apply, only updated error msg)
• Updated relevant documentation (docs/) or specification (x/<module>/spec/) (does not apply, only updated error msg)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[codecov-commenter]

Codecov Report

Merging #2387 (faeee41) into main (a278287) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2387   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files         175      175           
  Lines       12134    12134           
=======================================
  Hits         9655     9655           
  Misses       2050     2050           
  Partials      429      429           

Impacted Files	Coverage Δ
modules/core/keeper/msg_server.go	58.29% <0.00%> (ø)

[damiannolan]

Thanks! 🙏 Nice improvement

[crodriguezvega]

Thanks, @alizahidraja!

[colin-axner]

Thanks @alizahidraja! Unfortunately with middleware, these error messages can be misleading. If we have a middleware stack which is ICS29 and ICS20, if ICS20 returns an error in the application callback, the final error message will actually indicate that the module which failed was fee-middleware (which is incorrect).

I think it might make more sense to include the portID? We could also change the notion of the "module" variable to be a "middleware stack", though it'd be nice to think this approach out fully

[alizahidraja]

Thanks for the insights @colin-axner! Will update the code to cater for the issue mentioned

[alizahidraja]

Closing PR; Don't have access to the merging repo, will open a new one in the morning

[alizahidraja]

Continued here