added switch case to detect blank pointers in keeper

[alizahidraja]

Description

Added switch case to detect blank pointers in the keeper.

closes: #2268

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/) (not applicable)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[crodriguezvega]

Thanks for fixing this, @alizahidraja!

Could you also please try to add some tests for the empty pointer situations here?

[damiannolan]

Thanks for your contributions @alizahidraja, much appreciated! 🙏

I have some doubts over this code needing to change, but perhaps some additional tests could get to the bottom of it!

[alizahidraja]

@crodriguezvega will have a look and add some tests for empty pointers

[alizahidraja]

@crodriguezvega @damiannolan I added 2 new test cases and ran them on both, the switch case code and previous code; the previous code fail the new test cases with pointers

Please do have a look and lmk your thoughts

[crodriguezvega]

Thanks, @alizahidraja!

[colin-axner]

Thanks for picking this up @alizahidraja. It's a bit of a tricky issue so I appreciate your patience. See my latest comment. I think it makes sense to add this to the bottom of the keeper.go file

[alizahidraja]

No worries @colin-axner, I'll make a function to check for that at the bottom

[alizahidraja]

Added an isEmpty function at the bottom of the keeper

The final concern would be that the error message cannot specify if the keeper object is a struct or a pointer, dk if that is important, lmk what you guys think

[codecov-commenter]

Codecov Report

Merging #2403 (40f33c6) into main (7dcfc2c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
+ Coverage   78.63%   78.64%   +0.01%     
==========================================
  Files         178      178              
  Lines       12354    12365      +11     
==========================================
+ Hits         9714     9725      +11     
  Misses       2208     2208              
  Partials      432      432              

Impacted Files	Coverage Δ
modules/core/keeper/keeper.go	91.11% <100.00%> (+2.87%)	⬆️

[colin-axner]

Thanks @alizahidraja!

[colin-axner]

The final concern would be that the error message cannot specify if the keeper object is a struct or a pointer, dk if that is important, lmk what you guys think

No, I think as you have it now is great. We mostly just want to panic if something is misconfigured so the chain developer knows to look into the code