Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v4.2.x: bump SDK version to v0.45.10 #2588

Merged
merged 5 commits into from
Nov 4, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Oct 25, 2022

Description

This PR makes v4.2.x better.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@faddat faddat closed this Oct 25, 2022
@faddat faddat reopened this Oct 27, 2022
@colin-axner colin-axner changed the title patch v4.2.x release v4.2.x: bump SDK version to v0.45.10 Oct 27, 2022
@crodriguezvega
Copy link
Contributor

@faddat I opened this PR to address some review comments. If you would be so kind to merge it, then we can merge this one.

review comments for release/v4.2.x
@crodriguezvega
Copy link
Contributor

I will merge this PR now and fix the build problem separately. Thanks, @faddat!

@crodriguezvega crodriguezvega merged commit 2d94624 into cosmos:release/v4.2.x Nov 4, 2022
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 27, 2023
* use authtypes.NewModuleAddress

* apply version updates

* review comments

* add retract directive

Co-authored-by: catShaark <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: khanh-notional <[email protected]>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
* use authtypes.NewModuleAddress

* apply version updates

* review comments

* add retract directive

Co-authored-by: catShaark <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: khanh-notional <[email protected]>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
* use authtypes.NewModuleAddress

* apply version updates

* review comments

* add retract directive

Co-authored-by: catShaark <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: khanh-notional <[email protected]>
@ulbqb ulbqb mentioned this pull request Jul 31, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants